Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Aug 10, 2020

Description

Fix issue: #12592

The issue is: when download a file "aa/bb.txt" to c:\dir, when c:\dir\aa not exist, download will fail.
This is caused by a recent code re-orgnize in this cmdlet (in PR #12323), so GetFullReceiveFilePath() might will run 2 times, and the 2nd time will fail. We should only run GetFullReceiveFilePath() once for the cmdlet.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants