Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Sep 29, 2020

Description

design pass review in pass review in: Azure/azure-powershell-cmdlet-review-pr#567
the code change already in storage preview release branch with PR #12013

The feature target 10/27 release, anyway, it would be great if can release in 10/13 release.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel self-assigned this Sep 29, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small typo

Comment on lines +22 to +23
- `New-AzRmStorageShare`
- `Update-AzRmStorageShare`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `New-AzRmStorageShare`
- `Update-AzRmStorageShare`
- `New-AzStorageShare`
- `Update-AzStorageShare`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change log is right.
We have 2 set of File share cmdlet:

  1. Dataplane , like New-AzStorageShare
  2. Mgmt plane, like New-AzRmStorageShare.

The new properties only support on Mgmt plane, so should change the cmdlet name like "*-RmStorageShare"

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the explaination!

@isra-fel isra-fel merged commit db2017f into Azure:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants