Application Gateway Mutual Authentication Cmdlets.

[HemantErappa]

Description

Implements the cmdlets to support application gateway private link feature.

Design Review PR:
Azure/azure-powershell-cmdlet-review-pr#654

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[VeryEarly]

It looks to me you do not need so many cmdlet:
New-AzApplicationGatewayClientAuthConfiguration
New-AzApplicationGatewaySslProfile
New-AzApplicationGatewayTrustedClientCertificate

are enough, other cmdlets can be done by having a new cmdlet update-azapplicationgateway

[VeryEarly]

please rename TrustedClientCertificates as TrustedClientCertificate,
powershell use singularity for parameter names:
https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/design-guidelines/cmdlet-best-practices.md

[HemantErappa]

This is consistent with other parameter names in NewAzureApplicationGatewayCommand, like SslCertificates, HttpListeners, FrontendPorts, etc., which take a list of PSObjects. Also, the naming TrustedClientCertificates makes it clear to the customer that this parameter takes a list of PSObjects verses a parameter like SslPolicy which takes on a single PSObject.
https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.commands.network.newazureapplicationgatewaycommand?view=azurerm-ps

[isra-fel]

Yes, this parameter takes a list of objects, but it also takes one signle object, aka -TrustedClientCertificates @{...} is totally OK. That is why we ask everyone to use singular name.

Considering exisiting parameters I won't request you to revise, but I do hope you understand why.

[VeryEarly]

please rename SslProfiles as SslProfile
powershell use singularity for parameter names:
https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/design-guidelines/cmdlet-best-practices.md

[HemantErappa]

Same reason as above.

[VeryEarly]

is this operation sending any request to azure?
It looks like this cmdlet only update ps object in memory. If so, no need for support should process

[HemantErappa]

done

[VeryEarly]

can you remove localfeed and use published SDK instead?

[HemantErappa]

It looks to me you do not need so many cmdlet:
New-AzApplicationGatewayClientAuthConfiguration
New-AzApplicationGatewaySslProfile
New-AzApplicationGatewayTrustedClientCertificate

are enough, other cmdlets can be done by having a new cmdlet update-azapplicationgateway

ClientAuthConfiguration, SslProfile and TrustedClientCertificate also have parameters which cannot be set using set-azapplicationgateway. Please refer to Test-ApplicationGatewayCRUDWithMutualAuthentication in src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1 for examples. Also we have these cmndlets for other objects like sslcertificate, httplistener, etc., would be better to keep it for consistency :)

[isra-fel]

Yes, this parameter takes a list of objects, but it also takes one signle object, aka -TrustedClientCertificates @{...} is totally OK. That is why we ask everyone to use singular name.

Considering exisiting parameters I won't request you to revise, but I do hope you understand why.

[isra-fel]

/azp run azure-powershell - windows-powershell

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).