Skip to content

Conversation

@johunte
Copy link
Contributor

@johunte johunte commented Oct 22, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

irrogozh and others added 3 commits October 22, 2020 09:33
* Updated ConnectionMonitorEndpoint cmdlet

* Updated help files

* Fixed help files

* Suppressed breaking changes warnings
Azure#13001)

* Fixed bug in New-AzConnectionMonitorEndpoint cmdlet. Updated help file

* Fixed typo and add online version in help file
@johunte johunte requested a review from irrogozh October 22, 2020 17:21
@johunte johunte changed the title Release 2020 10 27 Updated Connection monitor endpoint cmdlet Oct 22, 2020
@johunte
Copy link
Contributor Author

johunte commented Oct 22, 2020

This PR contains only cherrypicks of commits from the Az.Network-preview branch and a single edit to the relevant changelog file to reflect the changes included

Copy link
Member

@irrogozh irrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ChangedLog I think you should also write that we add some parameters to ConnectionMonitorEndpoint (Scope, CoverageLevel and Type). Type became a mandatory parameter.

We also add DestinationPortBehavior parameter into NewNetworkWatcherConnectionMonitorProtocolConfigurationObject cmdlet

Also, New-ConnectionMonitorEndpointFilterItemObjectcmdlet was replaced with New-ConnectionMonitorEndpointScopeItemObject

@johunte johunte requested a review from irrogozh October 22, 2020 19:17
@dingmeng-xue
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit 0c7265b into Azure:release-2020-10-27 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants