[Costmanagement] Add CostManagement Generated Code and Tests #13539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test cases and example of CostManagement. * Modified test cases and example of CostManagement.
…into wyunchi/CostManagement
…re-powershell into wyunchi/CostManagement
…into wyunchi/CostManagement
dolauli
reviewed
Nov 24, 2020
| Query the usage data for scope defined. | ||
| .Description | ||
| Query the usage data for scope defined. | ||
| .Example |
dolauli
reviewed
Nov 24, 2020
src/CostManagement/docs/Invoke-AzCostManagementExecuteExport.md
Outdated
Show resolved
Hide resolved
dolauli
reviewed
Nov 24, 2020
wyunchi-ms
changed the title
dolauli
reviewed
Nov 24, 2020
src/CostManagement/custom/New-AzCostManagementQueryColumnObject.ps1
Outdated
Show resolved
Hide resolved
dolauli
reviewed
Nov 24, 2020
dolauli
requested changes
Nov 24, 2020
Contributor
dolauli
left a comment
dolauli
left a comment
There was a problem hiding this comment.
Some changes are required
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 2 pipeline(s). |
Contributor
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 2 pipeline(s). |
dolauli
reviewed
Dec 2, 2020
| Update operation requires latest eTag to be set in the request. | ||
| You may obtain the latest eTag by performing a get operation. | ||
| Create operation does not require eTag. | ||
| .Example |
Contributor
There was a problem hiding this comment.
Remove examples, outputs and link from the comments.
dolauli
reviewed
Dec 2, 2020
| Name <String>: The name of the column to group. | ||
| Type <QueryColumnType>: Has type of the column to group. | ||
| .Link | ||
| https://docs.microsoft.com/en-us/powershell/module/az.cost/invoke-azcostmanagementusagequery |
Contributor
There was a problem hiding this comment.
Link is incorrect here. should not az.cost. Just remove the link part.
dolauli
reviewed
Dec 2, 2020
dolauli
reviewed
Dec 2, 2020
dolauli
previously requested changes
Dec 2, 2020
Contributor
dolauli
left a comment
dolauli
left a comment
There was a problem hiding this comment.
- some examples are missing
- In customized ps1 scripts, examples and link are not needed.
wyunchi-ms
approved these changes
Dec 2, 2020
wyunchi-ms
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate CostManagement code base on Version '2020-06-01' and test all cmdlets except one Syntax of 'Invoke-AzCostManagementQuery'.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added