Skip to content

Conversation

@kenchenMicrosoft
Copy link
Contributor

@kenchenMicrosoft kenchenMicrosoft commented Dec 16, 2020

Description

  • Updated New-AzFirewallPolicyApplicationRule cmdlet:
    • Added parameter TargetUrl
    • Added parameter TerminateTLS
  • Added new cmdlets for Azure Firewall Premium Features
    • New-AzFirewallPolicyIntrusionDetection
    • New-AzFirewallPolicyIntrusionDetectionBypassTraffic
    • New-AzFirewallPolicyIntrusionDetectionSignatureOverride
  • Updated New-AzFirewallPolicy cmdlet:
    • Added parameter -SkuTier
    • Added parameter -Identity
    • Added parameter -UserAssignedIdentityId
    • Added parameter -IntrusionDetection
    • Added parameter -TransportSecurityName
    • Added parameter -TransportSecurityKeyVaultSecretId

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@kenchenMicrosoft kenchenMicrosoft changed the title Premium set and tls Added Premium and TLS support for Firewall Policy Dec 16, 2020
@wyunchi-ms
Copy link
Contributor

@kenchenMicrosoft One test case fails. Please fix it. Some of the error message is:

A total of 1 test files matched the specified pattern.
  [xUnit.net 00:00:23.76]     Commands.Network.Test.ScenarioTests.AzureFirewallPolicyTests.TestAzureFirewallPolicyPremiumFeatures [FAIL]
    X Commands.Network.Test.ScenarioTests.AzureFirewallPolicyTests.TestAzureFirewallPolicyPremiumFeatures [1s 235ms]
EXEC : error Message:  [D:\a\1\s\build.proj]
     System.Management.Automation.ParameterBindingException : A parameter cannot be found that matches parameter name 'SignatureOverrides'.
    Stack Trace:
       at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
     at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)

@saisujithreddym
Copy link
Contributor

retest

@isra-fel
Copy link
Member

@saisujithreddym please follow the instructions in log of azure-powershell - security-tools to prevent leaking sensitive info

@kenchenMicrosoft
Copy link
Contributor Author

@saisujithreddym please follow the instructions in log of azure-powershell - security-tools to prevent leaking sensitive info

The file in question was not needed and is now removed. Please review again.

@isra-fel isra-fel self-assigned this Dec 23, 2020
@isra-fel isra-fel merged commit 77e6ea8 into Azure:network-august Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants