[Storage] Support File share snapshot #14937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyunchi-ms
reviewed
May 11, 2021
wyunchi-ms
approved these changes
May 11, 2021
wyunchi-ms
pushed a commit
that referenced
this pull request
May 14, 2021
…ster (#14991) * [Storage] Support File share snapshot (#14937) * [Storage] Support File share snapshot * Update SRP SDK for other projects * fix comments * [Storage] Support Blob inventory (#14966) * [Storage] Support DefaultSharePermission and CrossTenantReplication (#14982) * [Storage] Support AllowCrossTenantReplication * [Storage] Support DefaultSharePermission * Add test and help example * remove the private SRP SDK, to use public released SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
design pass review in :
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/785
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/926
Please help to review the PR, and it currently depends on a private signed SDK, since the swagger PR still not merged. Azure/azure-rest-api-specs#14211
Will update the PR with released SDK after swagger merged and SDK released.
Or could we first merge this PR, then update it to released SDK when the swagger PR merge and SDK release (maybe in next release)?
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added- Remove-AzRmStorageShare behavior will change, breaking warning added before.