[Az.RecoveryServices.Backup] Fixed issues with StorageConfig #16003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The CI fails. Please fix it. |
Contributor
|
Hi @hiaga , please resolve the conflicts. Besides, as you updated the SDK version, all test cases must be re-recorded and their latest test recordings must be re-uploaded. |
Member
Author
I'm working on few more changes. I'll update the PR with re-recorded tests once ready |
hiaga
force-pushed
the
hiaga/storageConfig
branch
2 times, most recently
from
a98a974 to
967b1db
Compare
Member
Author
|
@BethanyZhou I'm re-recording the test cases, should be ready by tomorrow. In the meantime please have a look. |
BethanyZhou
reviewed
Oct 26, 2021
hiaga
force-pushed
the
hiaga/storageConfig
branch
from
967b1db to
9108dfa
Compare
hiaga
force-pushed
the
hiaga/storageConfig
branch
2 times, most recently
from
9e27f9b to
be99c59
Compare
BethanyZhou
requested review from
Sandido,
bilaakpan-ms,
grizzlytheodore and
haagha
as code owners
BethanyZhou
reviewed
Oct 27, 2021
Contributor
There was a problem hiding this comment.
Suggested change
| * [Breaking Change] Get-AzRecoveryServicesBackupJob, Get-AzRecoveryServicesBackupContainer and Get-AzRecoveryServicesBackupProtectableItem commands will only support BackupManagementType MAB instead of MARS alias, changes will take effect from upcoming breaking release. | |
| * Added breaking change warning: `Get-AzRecoveryServicesBackupJob`, `Get-AzRecoveryServicesBackupContainer` and `Get-AzRecoveryServicesBackupProtectableItem` commands will only support `BackupManagementType MAB` instead of `MARS` alias, changes will take effect from upcoming breaking release. |
added NodesList and AutoProtectionPolicy to Get-AzRecoveryServicesBackupProtectableItem Cmdlets fixed GetItemsForContainerParamSet to support fetching the MAB backup item fixed Get-AzRecoveryServicesBackupContainer to support BackupManagementType MAB instead of MARS [Breaking Change Warning] Get-AzRecoveryServicesBackupJob, Get-AzRecoveryServicesBackupContainer and Get-AzRecoveryServicesBackupProtectableItem commands will only support BackupManagementType MAB instead of MARS alias re-recorded the test ContainerTests
hiaga
force-pushed
the
hiaga/storageConfig
branch
from
f0bdd00 to
625792a
Compare
hiaga
force-pushed
the
hiaga/storageConfig
branch
from
625792a to
8511d01
Compare
BethanyZhou
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues with StorageConfig in setting storage redundancy type.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added