Skip to content

Conversation

@amisi01
Copy link
Contributor

@amisi01 amisi01 commented Oct 22, 2021

Added Latest Restorable TS Support for MongoDB. Also, Updated account api to update BackupRedundancy.

Description

* Added New Cmdlet for getting backup information for MongoDB.
* Update New/Update database account cmdlet to update backup redundancy
* Added New Cmdlet for getting locations

Checklist

* Update New/Update database account cmdlet to update backupredundancy
* Added New Cmdlet for getting locations
@BethanyZhou
Copy link
Contributor

Hi @amisi01 , looks like Microsoft.Azure.Management.CosmosDB 3.2.0 is not public available by far, please refer to: https://www.nuget.org/packages/Microsoft.Azure.Management.CosmosDB/

@BethanyZhou BethanyZhou added Contains Breaking Change This PR contains breaking change needs-revision labels Oct 25, 2021
@amisi01
Copy link
Contributor Author

amisi01 commented Oct 25, 2021

Hi @amisi01 , looks like Microsoft.Azure.Management.CosmosDB 3.2.0 is not public available by far, please refer to: https://www.nuget.org/packages/Microsoft.Azure.Management.CosmosDB/

Hi Beisi,
We have swagger PR which is going to be checked in by tomorrow morning and we'll have updated .net sdk with new version. The updated version will mostly be the same that i updated to but if not, i'll update code to correct version.
Considering that, we are on real tight deadline and it is important for us that these changes get released as part of this build, so i just wanted to get everything ready (code reviewed and all comments addressed) except version update and CI pipeline passing. I have already validated the changes locally.

Thanks a lot for understanding our situation.

@BethanyZhou BethanyZhou added this to the Oct 2021 (2021-11-02) milestone Oct 25, 2021
@BethanyZhou
Copy link
Contributor

Hi @amisi01 ,

I would like to suggest you to upload a local feed in azure-powershell//tools/LocalFeed to verify the CI pipeline first, so that we can fix any CI issue in advance.

When your SDK is available, just remove the local feed.

…ation and also updated help files. Updated mgmt cosmosdb version to 3.3.0
@amisi01 amisi01 force-pushed the users/amisi/latestrestorablets_mongodb_1015 branch from ad843cb to 5ee0e05 Compare October 25, 2021 23:41
@BethanyZhou
Copy link
Contributor

As your SDK version changes, all test cases must be re-recorded. Could you re-recorded all tests?

@BethanyZhou BethanyZhou changed the base branch from main to release-2021-11-02 October 26, 2021 07:38
@amisi01
Copy link
Contributor Author

amisi01 commented Oct 26, 2021

Hi @amisi01 , looks like Microsoft.Azure.Management.CosmosDB 3.2.0 is not public available by far, please refer to: https://www.nuget.org/packages/Microsoft.Azure.Management.CosmosDB/

I updated localfeed to 3.3.0. Will update it to correct version once .net sdk is released

@amisi01 amisi01 force-pushed the users/amisi/latestrestorablets_mongodb_1015 branch from 172e1c4 to 0b92bbf Compare October 27, 2021 04:32
@BethanyZhou BethanyZhou changed the base branch from release-2021-11-02 to main October 27, 2021 04:58
@BethanyZhou BethanyZhou force-pushed the users/amisi/latestrestorablets_mongodb_1015 branch from 0b92bbf to f4a2f26 Compare October 27, 2021 05:03
@BethanyZhou
Copy link
Contributor

BethanyZhou commented Oct 27, 2021

Hi @amisi01 , we understand you have a very tight timeline, so I have to tell you I'm afraid that you may not catch the nearest release 11/02. I will move it to next release 12/07. Is this time okay for you? Please let me know when the SDK is ready.

@amisi01
Copy link
Contributor Author

amisi01 commented Oct 27, 2021

Hi @amisi01 , we understand you have a very tight timeline, so I have to tell you I'm afraid that we may not catch the nearest release 11/02. I will move it to next release 12/07. Is this time okay for you? Please let me know when the SDK is ready.

Hi Beisi, we'll have .net sdk ready by tomorrow evening. Is it possible that we can complete this PR by tomorrow night then is it okay to get it as part of 11/02 release?

@amisi01
Copy link
Contributor Author

amisi01 commented Oct 27, 2021

Hi @amisi01 , we understand you have a very tight timeline, so I have to tell you I'm afraid that we may not catch the nearest release 11/02. I will move it to next release 12/07. Is this time okay for you? Please let me know when the SDK is ready.

Hi Beisi, we'll have .net sdk ready by tomorrow evening. Is it possible that we can complete this PR by tomorrow night then is it okay to get it as part of 11/02 release?

PR is ready for check in. Only, i am waiting for .net sdk to complete it.

@BethanyZhou BethanyZhou removed the Contains Breaking Change This PR contains breaking change label Oct 27, 2021
@amisi01 amisi01 force-pushed the users/amisi/latestrestorablets_mongodb_1015 branch from f4a2f26 to f1cc48d Compare October 27, 2021 08:29
@amisi01
Copy link
Contributor Author

amisi01 commented Oct 27, 2021

Hi @amisi01 , we understand you have a very tight timeline, so I have to tell you I'm afraid that you may not catch the nearest release 11/02. I will move it to next release 12/07. Is this time okay for you? Please let me know when the SDK is ready.

Hi Beisi, dotnet sdk is released. I have updated powershell PR to remove the localfeed changes and CI looks okay. Could you please take a look at the changes and merge it if looks okay. Thanks

@BethanyZhou BethanyZhou changed the base branch from main to release-2021-11-02 October 28, 2021 01:42
@BethanyZhou BethanyZhou force-pushed the users/amisi/latestrestorablets_mongodb_1015 branch from b661dd1 to ebb6d73 Compare October 28, 2021 01:52
@BethanyZhou BethanyZhou merged commit f7c4d40 into Azure:release-2021-11-02 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants