-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Generate GitHub Copilot instructions with clear module vs project architecture #28402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
… repository Co-authored-by: isra-fel <11371776+isra-fel@users.noreply.github.com>
…roubleshooting Co-authored-by: isra-fel <11371776+isra-fel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…aches - Correct terminology from "SDK-based modules" to "SDK-based projects" - Add Architecture Overview section explaining modules vs projects - Clarify that development approaches apply to projects, not entire modules - Add explanation of hybrid modules containing both project types - Update references throughout document for consistency Co-authored-by: isra-fel <11371776+isra-fel@users.noreply.github.com>
I've updated the instructions to correctly distinguish between modules and projects. The terminology now clarifies that development approaches (SDK-based vs AutoRest-based) apply to individual projects within modules, not entire modules, since modules can be hybrid containing both types of projects. Added an Architecture Overview section explaining this distinction and updated all references throughout the document. See commit eb4147c.
I've corrected the terminology throughout the instructions to distinguish modules vs projects. The document now clearly explains that:
Updated all sections to refer to "SDK-based projects" and "AutoRest-based projects" instead of modules. See commit eb4147c. |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive GitHub Copilot instructions to help developers work effectively in the Azure PowerShell repository, focusing on the distinction between modules and projects within the complex multi-approach architecture.
- Provides clear guidance on build system usage with critical timing expectations and "NEVER CANCEL" warnings
- Establishes manual validation workflows that emphasize testing functionality beyond just building
- Documents the hybrid architecture where modules can contain both SDK-based and AutoRest-generated projects
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This PR adds comprehensive GitHub Copilot instructions to help developers work effectively in the Azure PowerShell repository. The instructions provide detailed guidance for building, testing, and developing in this complex codebase containing 200+ PowerShell modules.
Architecture Clarification
A key focus of these instructions is properly distinguishing the repository's architecture:
Az.Compute) that can consist of multiple projectsAz.Resourceswith both approaches)The development approaches (SDK-based vs AutoRest-based) apply to individual projects within modules, not entire modules themselves, since modules can be hybrid containing both types of projects.
Key Features
Build System Guidance
Prerequisites and Setup
Manual Validation Scenarios
The instructions emphasize that building alone is insufficient - developers must manually test functionality:
Repository Structure Explanation
Comprehensive Troubleshooting
Timing Expectations
The instructions begin with a firm directive to follow these guidelines first before searching for additional context, ensuring Copilot prioritizes the documented workflows over generic approaches.
Fixes #28401.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.