Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ARM VNET + Internal Workloads + Soap Api's #2971

Merged
merged 4 commits into from Sep 22, 2016

Conversation

@solankisamir
Copy link
Member

commented Sep 20, 2016

Comments

  • Upgrade ApiMAnagement nuget to 3.0.0-preview
  • Added test for WSDL Importing Exporting
  • Added test for Swagger Importing Exporting
  • Added test for ARM VNET both with External and Internal VIP
  • Fixed powershell Issue on ApiManagement
    #2622 - Retrieve State
    from Server
  • Fixed Powershell Issue on ApiManagement
    #2606 - Use Patch
  • Regenerated all Session Records
  • Deprecated cmdlet ManageVirtualNetwork
  • Refactored RP tests for proper cleanup in Finally block
  • Updated documentation

This checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices here.

Below in Overall Changes, check off the boxes that apply to your PR. For the categories that you did not check off, you can remove them from this body. Within each of the categories that you did select, make sure that you can check off all of the boxes.

For information on cleaning up the commits in your pull request, click here.

Overall Changes

General

  • Title of the PR is clear and informative
  • There are a small number of commits that each have an informative message
  • If it applies, references the bug/issue that the PR fixes
  • All files have the Microsoft copyright header
  • Cmdlets refer to management libraries through nuget references - no dlls are checked in
  • The PR does not introduce breaking changes (unless a major version change occurs in the assembly and module)

Tests

  • PR includes test coverage for the included changes
  • Tests must use xunit, and should either use Moq to mock management client calls, or use the scenario test framework
  • PowerShell scripts used in tests must not use hard-coded values for location
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for existing resources
  • Tests should not use App.config files for settings
  • Tests should use the built-in PowerShell functions for generating random names when unique names are necessary - this will store names in the test recording
  • Tests should use Start-Sleep to pause rather than Thread.Sleep

Cmdlet Signature

  • Cmdlet name uses an approved PowerShell verb - use the enums for VerbsCommon, VerbsCommunication, VerbsLifecycle, VerbsOther whenever possible
  • Cmdlet noun name uses the AzureRm prefix for management cmdlets, and the Azure prefix for data plane cmdlets
  • Cmdlet specifies the OutputType attribute if any output is produced; if the cmdlet produces no output, it should implement a PassThrough parameter
  • If the cmdlet makes changes or has side effects, it should implement ShouldProcess and have SupportShouldProcess = true specified in the cmdlet attribute. See a discussion about correct ShouldProcess implementation here
  • Cmdlets should derive from AzureRmCmdlet for management cmdlets, and AzureDataCmdlet for data cmdlets
  • If multiple parameter sets are implemented, the cmdlet should specify a DefaultParameterSetName in its cmdlet attribute

Parameters

  • Cmdlets should have no more than four positional parameters
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets
  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet
  • Parameters should be explicitly marked as Mandatory or not, and should contain a HelpMessage
  • No parameter is of type object.
    • Management cmdlets should have the following parameters and aliases:
      • ResourceGroupName with (optional) alias to ResourceGroup type string marked as [ValueFromPipelineByPropertyName]
      • Name with alias to ResourceName type string marked as [ValueFromPipelineByPropertyName]
      • Location (if appropriate) type string
      • Tag, type HashTable

Parameters and the Pipeline

  • Complex parameters should take values from the pipeline when possible, and certainly when they match the output type of another cmdlet
  • Only one parameter should use ValueFromPipeline per parameter set; parameters from different parameter sets may have this attribute, but should not be convertible
  • No parameter is of type object
  • Each management cmdlet should have a parameter set that takes ResourceGroupName and Name from the pipeline by property value
  • For a given resource type, it should be possible to pipe the output of Get and New cmdlets to the input of Set, Update, Remove and other action cmdlets for that resource
Upgrade to 3.0.0.0-preview package - Support for ARM VNET + ILB + Soap
- Upgrade ApiMAnagement nuget to 3.0.0-preview
- Added test for WSDL Importing Exporting
- Added test for Swagger Importing Exporting
- Added test for ARM VNET both with External and Internal VIP
- Fixed powershell Issue on ApiManagement
#2622 - Retrieve State
from Server
- Fixed Powershell Issue on ApiManagement
#2606 - Use Patch
- Regenerated all Session Records
- Deprecated cmdlet ManageVirtualNetwork
- Refactored RP tests for proper cleanup in Finally block

@solankisamir solankisamir changed the title Upgrade to 3.0.0.0-preview package - Support for ARM VNET + ILB + Soap Support for ARM VNET + Internal Workloads + Soap Api's Sep 20, 2016

@cormacpayne

This comment has been minimized.

HelpMessage = "Identifier of the virtual network.")]
[ValidateNotNullOrEmpty]
public Guid VnetId { get; set; }
public string SubnetResourceId { get; set; }

This comment has been minimized.

Copy link
@cormacpayne

cormacpayne Sep 20, 2016

Member

@solankisamir this is a breaking change; all existing scripts that use this cmdlet will no longer work (both SubnetName and VnetId were required parameters and are now removed). What is the reaosn behind this change?

This comment has been minimized.

Copy link
@solankisamir

solankisamir Sep 22, 2016

Author Member

as discussed offline

@cormacpayne

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

@azuresdkci retest this please

@cormacpayne

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

@solankisamir Hey Samir, would you mind pulling from dev to get the latest changes that fix the on-demand build?

Upgrade to 3.0.0.0-preview package - Support for ARM VNET + ILB + Soap
- Upgrade ApiMAnagement nuget to 3.0.0-preview
- Added test for WSDL Importing Exporting
- Added test for Swagger Importing Exporting
- Added test for ARM VNET both with External and Internal VIP
- Fixed powershell Issue on ApiManagement
#2622 - Retrieve State
from Server
- Fixed Powershell Issue on ApiManagement
#2606 - Use Patch
- Regenerated all Session Records
- Deprecated cmdlet ManageVirtualNetwork
- Refactored RP tests for proper cleanup in Finally block
@solankisamir

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2016

@cormacpayne On Demand Passed.

@cormacpayne

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

@solankisamir approved review changes since we are taking the breaking change this release

@cormacpayne cormacpayne merged commit 550d52b into Azure:dev Sep 22, 2016

1 check passed

default Build finished.
Details

@solankisamir solankisamir deleted the solankisamir:apim-vnet-soap branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.