Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Active-Active Gateway feature commandlets #2982

Merged
merged 7 commits into from Sep 22, 2016

Conversation

@Nilambari
Copy link
Member

commented Sep 21, 2016

Changed the bool param: to SwitchParameter to enable/disable Active-Active feature while creating / updating virtual network gateway.
Testing is done and working fine.

@Nilambari

This comment has been minimized.

@@ -85,9 +85,8 @@ public class NewAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd

[Parameter(
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "Active-Active feature flag")]
public bool ActiveActive { get; set; }

This comment has been minimized.

Copy link
@cormacpayne

cormacpayne Sep 21, 2016

Member

@Nilambari this is a breaking change; scripts using the ActiveActive parameter for this cmdlet will no longer work.

This comment has been minimized.

Copy link
@Nilambari

Nilambari Sep 21, 2016

Author Member

Yes but these command lets are not yet released as in there are no customers who use these command lets yet. We will release the at Ignite. They were just part of last PS release but no customers using it yet.

This comment has been minimized.

Copy link
@markcowl

markcowl Sep 21, 2016

Member

It doesn't matter how many customers are using the cmdlet - you need to obsolete parameters, preferrably several months before deleteing them

// Mandatory = false,
// ValueFromPipelineByPropertyName = true,
// HelpMessage = "ActiveActive feature flag")]
//public bool ActiveActive { get; set; }

This comment has been minimized.

Copy link
@cormacpayne

cormacpayne Sep 21, 2016

Member

@Nilambari same comment as above

This comment has been minimized.

Copy link
@Nilambari

Nilambari Sep 21, 2016

Author Member

Yes but these command lets are not yet released as in there are no customers who use these command lets yet. We will release the at Ignite. They were just part of last PS release but no customers using it yet.

This comment has been minimized.

Copy link
@markcowl

markcowl Sep 21, 2016

Member

Same comment

@cormacpayne

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

@Nilambari Hey Nilambari, would you mind pulling from dev to get the latest changes that fix the on-demand build?

@Nilambari

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2016

@cormacpayne

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

@Nilambari approving changes since we are taking a breaking change for this release

@Nilambari

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2016

Thanks. Can you Please merge the PR? Thanks!

@cormacpayne cormacpayne merged commit 376bbcd into Azure:dev Sep 22, 2016

1 check passed

default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.