New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the SetParameters.xml file to override package configuration when publishing a webdeploy package to an azure website. #316

Merged
merged 4 commits into from May 26, 2015

Conversation

Projects
None yet
7 participants
@naeemkhedarun
Contributor

naeemkhedarun commented Apr 2, 2015

I've added support for specifying a parameters file when publishing a package to an azure website.

For example:

 Publish-AzureWebsiteProject -Name nymtest -Package .\App.Api.zip -SetParametersFile .\App.Api.SetParameters.xml

Any help getting this merged will be very appreciated! Thanks for the fantastic cmdlets.

Add support for the SetParameters.xml file to override package config…
…uration when publishing a webdeploy package to an azure website.
@azuresdkci

This comment has been minimized.

Show comment
Hide comment
@azuresdkci

azuresdkci Apr 2, 2015

Can one of the admins verify this patch?

azuresdkci commented Apr 2, 2015

Can one of the admins verify this patch?

@azurecla

This comment has been minimized.

Show comment
Hide comment
@azurecla

azurecla Apr 2, 2015

Hi @naeemkhedarun, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

azurecla commented Apr 2, 2015

Hi @naeemkhedarun, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@azurecla

This comment has been minimized.

Show comment
Hide comment
@azurecla

azurecla Apr 2, 2015

@naeemkhedarun, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, AZPRBOT;

azurecla commented Apr 2, 2015

@naeemkhedarun, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, AZPRBOT;

@azurecla azurecla added cla-signed and removed cla-required labels Apr 2, 2015

@markcowl

This comment has been minimized.

Show comment
Hide comment
@markcowl

markcowl Apr 15, 2015

Member

@azuresdkci test this please

Member

markcowl commented Apr 15, 2015

@azuresdkci test this please

@naeemkhedarun

This comment has been minimized.

Show comment
Hide comment
@naeemkhedarun

naeemkhedarun Apr 17, 2015

Contributor

@markcowl Hey Mark, if I can help to get this merged or you want any changes made please get in touch!

Contributor

naeemkhedarun commented Apr 17, 2015

@markcowl Hey Mark, if I can help to get this merged or you want any changes made please get in touch!

@naeemkhedarun

This comment has been minimized.

Show comment
Hide comment
@naeemkhedarun

naeemkhedarun May 3, 2015

Contributor

@markcowl Hey Mark it has been a few weeks, would you like me to reintegrate this PR with the latest commits?

Contributor

naeemkhedarun commented May 3, 2015

@markcowl Hey Mark it has been a few weeks, would you like me to reintegrate this PR with the latest commits?

@markcowl

This comment has been minimized.

Show comment
Hide comment
@markcowl

markcowl May 4, 2015

Member

@naeemkhedarun Sorry for the delay, We are merging in some private changes today, and we will retun and take a look at the issues once that is complete

Member

markcowl commented May 4, 2015

@naeemkhedarun Sorry for the delay, We are merging in some private changes today, and we will retun and take a look at the issues once that is complete

@markcowl

This comment has been minimized.

Show comment
Hide comment
@markcowl

markcowl May 15, 2015

Member

@naeemkhedarun looks like this makes the publish-azurewebsites tests fail. Can you take a look?

Member

markcowl commented May 15, 2015

@naeemkhedarun looks like this makes the publish-azurewebsites tests fail. Can you take a look?

@naeemkhedarun

This comment has been minimized.

Show comment
Hide comment
@naeemkhedarun

naeemkhedarun May 20, 2015

Contributor

Thanks @markcowl I'll get this sorted!

Contributor

naeemkhedarun commented May 20, 2015

Thanks @markcowl I'll get this sorted!

@markcowl

This comment has been minimized.

Show comment
Hide comment
@markcowl

markcowl May 22, 2015

Member

@naeemkhedarun Code complete is today. Can you please update this?

Member

markcowl commented May 22, 2015

@naeemkhedarun Code complete is today. Can you please update this?

@naeemkhedarun

This comment has been minimized.

Show comment
Hide comment
@naeemkhedarun

naeemkhedarun May 22, 2015

Contributor

@markcowl working on it now!

Contributor

naeemkhedarun commented May 22, 2015

@markcowl working on it now!

@naeemkhedarun

This comment has been minimized.

Show comment
Hide comment
@naeemkhedarun

naeemkhedarun May 23, 2015

Contributor

@azuresdkci test this please

Contributor

naeemkhedarun commented May 23, 2015

@azuresdkci test this please

@markcowl

This comment has been minimized.

Show comment
Hide comment
@markcowl

markcowl May 26, 2015

Member

@azuresdkci add to whitelist

Member

markcowl commented May 26, 2015

@azuresdkci add to whitelist

@markcowl

This comment has been minimized.

Show comment
Hide comment
@markcowl

markcowl May 26, 2015

Member

@NaveenGoli Can you review this PR please?

Member

markcowl commented May 26, 2015

@NaveenGoli Can you review this PR please?

@stankovski

This comment has been minimized.

Show comment
Hide comment
@stankovski

stankovski May 26, 2015

Member

@azuresdkci retest this please

Member

stankovski commented May 26, 2015

@azuresdkci retest this please

@NaveenGoli

This comment has been minimized.

Show comment
Hide comment
@NaveenGoli

NaveenGoli May 26, 2015

Contributor

revierwed

Contributor

NaveenGoli commented May 26, 2015

revierwed

hovsepm added a commit that referenced this pull request May 26, 2015

Merge pull request #316 from naeemkhedarun/dev
Add support for the SetParameters.xml file to override package configuration when publishing a webdeploy package to an azure website.

@hovsepm hovsepm merged commit 2be1493 into Azure:dev May 26, 2015

1 check passed

default Build finished.
Details

markcowl pushed a commit that referenced this pull request Jan 14, 2016

hovsepm pushed a commit that referenced this pull request May 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment