From 437b22da4320fe953f879c4bb5be929c69e42fcb Mon Sep 17 00:00:00 2001 From: Haridarshan Hosakere Sudhakar Date: Mon, 5 Mar 2018 11:04:35 -0800 Subject: [PATCH 1/2] add breaking change instructions --- .../GetAzureRoleDefinitionCommand.cs | 3 +++ .../documentation/upcoming-breaking-changes.md | 16 +++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs b/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs index dbe2f1d3683d..eb8e50c18455 100644 --- a/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs +++ b/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs @@ -48,6 +48,7 @@ public class GetAzureRoleDefinitionCommand : ResourcesBaseCmdlet [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.RoleDefinitionName, HelpMessage = "If specified, displays the the roles at and below scope.")] [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.RoleDefinitionCustom, HelpMessage = "If specified, displays the the roles at and below scope.")] + [Obsolete("GEt-AzureRmRoleDefinition: The parameter \"AtScopeAndBelow\" is being removed in an upcoming breaking change release.")] public SwitchParameter AtScopeAndBelow { get; set; } public override void ExecuteCmdlet() @@ -55,7 +56,9 @@ public override void ExecuteCmdlet() FilterRoleDefinitionOptions options = new FilterRoleDefinitionOptions { CustomOnly = Custom.IsPresent ? true : false, + #pragma warning disable 0618 ScopeAndBelow = AtScopeAndBelow.IsPresent ? true : false, + #pragma warning restore 0618 Scope = Scope, ResourceIdentifier = new ResourceIdentifier { diff --git a/src/ResourceManager/Resources/documentation/upcoming-breaking-changes.md b/src/ResourceManager/Resources/documentation/upcoming-breaking-changes.md index e01c405de7a3..e7d7db4ce3ba 100644 --- a/src/ResourceManager/Resources/documentation/upcoming-breaking-changes.md +++ b/src/ResourceManager/Resources/documentation/upcoming-breaking-changes.md @@ -25,4 +25,18 @@ https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes/breaking-change-template.md --> -# Upcoming Breaking Changes \ No newline at end of file +# Upcoming Breaking Changes + +The following cmdlets were affected this release: + +**Get-AzureRmRoleDefinition** +- Parameter "AtScopeAndBelow" is being removed. + +```powershell + +# Old +# Get-AzureRmRoleDefinition [other required parameters] -AtScopeAndBelow + +# New +# Get-AzureRmRoleDefinition [other required parameters] +``` \ No newline at end of file From ee7b893667554cd3ff9b758d41e42eee836b611a Mon Sep 17 00:00:00 2001 From: Haridarshan Hosakere Sudhakar Date: Mon, 5 Mar 2018 11:30:07 -0800 Subject: [PATCH 2/2] fix typo --- .../RoleDefinitions/GetAzureRoleDefinitionCommand.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs b/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs index eb8e50c18455..4939caf8d8dc 100644 --- a/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs +++ b/src/ResourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs @@ -48,7 +48,7 @@ public class GetAzureRoleDefinitionCommand : ResourcesBaseCmdlet [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.RoleDefinitionName, HelpMessage = "If specified, displays the the roles at and below scope.")] [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.RoleDefinitionCustom, HelpMessage = "If specified, displays the the roles at and below scope.")] - [Obsolete("GEt-AzureRmRoleDefinition: The parameter \"AtScopeAndBelow\" is being removed in an upcoming breaking change release.")] + [Obsolete("Get-AzureRmRoleDefinition: The parameter \"AtScopeAndBelow\" is being removed in an upcoming breaking change release.")] public SwitchParameter AtScopeAndBelow { get; set; } public override void ExecuteCmdlet()