Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating API for custom domain in Front Door #5970

Merged
merged 4 commits into from Apr 15, 2019

Conversation

sfiguemsft
Copy link
Member

@sfiguemsft sfiguemsft commented Apr 12, 2019

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use a parameter for resource locations with the defaultValue set to resourceGroup().location
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values)
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/best-practices.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@sfiguemsft
Copy link
Member Author

Added .ci_skip

For CI to succeed the specified domain would have map via a CNAME to the Front Door address.

An example would be:

AFD hostname: contoso.azurefd.net
CNAME www.contoso.com would map to contoso.azurefd.net

@bmoore-msft
Copy link
Collaborator

Can you take the gen parameters out (otherwise someone will expect them to work some day) and a note to the readme about that requirement?

@bmoore-msft bmoore-msft merged commit 112e220 into Azure:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants