Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage custom domain indirect validation does not work #4995

Closed
ghost opened this issue Jan 7, 2019 · 1 comment
Closed

Storage custom domain indirect validation does not work #4995

ghost opened this issue Jan 7, 2019 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented Jan 7, 2019

The az cli uses another argument for the custom domain verification (broken) as the REST API offers (works).

We are using the REST API as a workaround because the az cli is broken.
The command
account update --use-subdomain true --custom-domain xxx --name xxx --subscription xxx
doesn't update the attribute "useSubDomain".

Funfact: The REST API doesn't use "useSubDomain" it uses "useSubDomainName".
After the REST call:
curl --request PATCH --data '{"properties": {"customDomain": {"name": "xxx", "useSubDomainName": true}}}' -H "Authorization: Bearer xxx" -H "Content-Type: application/json" https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9407/providers/Microsoft.Storage/storageAccounts/sto8596?api-version=2018-07-01

the config get changed to:

"customDomain": { "name": "xxx", "useSubDomain": null, "useSubDomainName": "true" },

and everything works as expected.

Relatet issue in another project: hashicorp/terraform-provider-azurerm#2542

@jhendrixMSFT
Copy link
Member

This was fixed in #4938

mccleanp pushed a commit that referenced this issue Mar 23, 2022
* Add collection endpoint

* Fix model issue

* Run prettier check

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Address PR comments

* Rename common fields

* Add extra fields

* Fix check issues

* Add tenant id

* Run prettier check

* Update specification/apisecurity/resource-manager/Microsoft.ApiSecurity/preview/2021-03-01-preview/apisecurity.json

Co-authored-by: Arcturus <ufo54153@gmail.com>

* Update specification/apisecurity/resource-manager/Microsoft.ApiSecurity/preview/2021-03-01-preview/apisecurity.json

Co-authored-by: Arcturus <ufo54153@gmail.com>

* Update specification/apisecurity/resource-manager/Microsoft.ApiSecurity/preview/2021-03-01-preview/apisecurity.json

Co-authored-by: Arcturus <ufo54153@gmail.com>

* Update specification/apisecurity/resource-manager/Microsoft.ApiSecurity/preview/2021-03-01-preview/apisecurity.json

Co-authored-by: Arcturus <ufo54153@gmail.com>

* Address PR comments

* Address PR comments

* Address PR comments

Co-authored-by: Arcturus <ufo54153@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant