Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breaking change tool and oav #3028

Merged
merged 1 commit into from May 9, 2018

Conversation

vladbarosan
Copy link

@vladbarosan vladbarosan commented May 7, 2018

No description provided.

@AutorestCI
Copy link

AutorestCI commented May 7, 2018

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented May 7, 2018

Automation for azure-libraries-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented May 7, 2018

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented May 7, 2018

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@hovsepm
Copy link
Contributor

hovsepm commented May 7, 2018

@vladbarosan why do we have "package-lock.json" file in the repo? this should be just a local temporary file that is created after npm install command.

@hovsepm
Copy link
Contributor

hovsepm commented May 7, 2018

@amarzavery since you were the original creator of this file :) Could you explain why do we need it in the repo?

@vladbarosan
Copy link
Author

vladbarosan commented May 7, 2018

@hovsepm not sure whats the history of it but since npm 5.1 package.json indeed trumps the lock file when using npm install. Unless we want to move to npm ci which was released in the latest npm version we can remove the lock file. ( npm ci uses the lock file)

@vladbarosan
Copy link
Author

synced with @amarzavery and will be staying with npm install for the time being.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@hovsepm
Copy link
Contributor

hovsepm commented May 7, 2018

@sarangan12 could you take a look and LMK if you are ok with merging this PR?

@vladbarosan vladbarosan merged commit 19dd1c4 into Azure:master May 9, 2018
@sarangan12 sarangan12 removed the review label May 9, 2018
@vladbarosan vladbarosan deleted the updateBreakingChange branch November 21, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants