Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Gateway - Adds Rewrite rule set for Header CRUD #4331

Conversation

@sai-manoj-kumar
Copy link

commented Oct 25, 2018

Adds the structure of rewriteRuleSets in the applicationGatewayProperties.
Adds recursively the sub structures in the rewriteRuleSet.
Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

sai-manoj-kumar added some commits Oct 25, 2018

Adds Rewrite rule set for Header CRUD
Adds the structure of rewriteRuleSets in the applicationGatewayProperties.
Adds recursively the sub structures in the rewriteRuleSet.
Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule.
@AutorestCI

This comment has been minimized.

Copy link

commented Oct 25, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci

This comment has been minimized.

Copy link
Collaborator

commented Oct 25, 2018

Can one of the admins verify this patch?

@AutorestCI

This comment has been minimized.

Copy link

commented Oct 25, 2018

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#395

@AutorestCI

This comment has been minimized.

Copy link

commented Oct 25, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI

This comment has been minimized.

Copy link

commented Oct 25, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4017

@AutorestCI

This comment has been minimized.

Copy link

commented Oct 25, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI

This comment has been minimized.

Copy link

commented Oct 25, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@sai-manoj-kumar sai-manoj-kumar changed the title Adds Rewrite rule set for Header CRUD Application Gateway - Adds Rewrite rule set for Header CRUD Oct 26, 2018

@MikhailTryakhov

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

do we need to create any examples?

@sai-manoj-kumar sai-manoj-kumar changed the base branch from dev-network-Microsoft.Network-2018-10-01 to network-november-release Nov 3, 2018

@sai-manoj-kumar

This comment has been minimized.

Copy link
Author

commented Nov 9, 2018

do we need to create any examples?
@MikhailTryakhov , I have added the examples.

@lmazuel lmazuel added the Reassign label Nov 9, 2018

@azuresdkci azuresdkci requested a review from jianghaolu Nov 9, 2018

@azuresdkci azuresdkci assigned dsgouda and unassigned jianghaolu Nov 13, 2018

@azuresdkci azuresdkci requested a review from dsgouda Nov 13, 2018

@dsgouda dsgouda added the ARM-overdue label Nov 14, 2018

sai-manoj-kumar added some commits Nov 14, 2018

@dsgouda
Copy link
Contributor

left a comment

LGTM, will merge when CIs pass. By passing ARM review since this is high pri

@sai-manoj-kumar

This comment has been minimized.

Copy link
Author

commented Nov 14, 2018

Checks have passed but it is not merged automatically. Should we merge it manually?

@MikhailTryakhov MikhailTryakhov merged commit 633d12d into Azure:network-november-release Nov 14, 2018

12 of 14 checks passed

SDK Generation - Go
Details
SDK Generation - Node
Details
# Automation for azure-sdk-for-go # Automation for azure-sdk-for-go
Details
Breaking Changes No potential breaking changes
Details
Linter Diff 0 new errors / 1 new warning
Details
Model Validator
Details
SDK Generation - Java
Details
SDK Generation - Python
Details
SDK Generation - Ruby
Details
SDK Generation - TypeScript
Details
Semantic Validator
Details
Syntax Validator
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

jcgknudson added a commit to jcgknudson/azure-rest-api-specs that referenced this pull request Nov 14, 2018

dsgouda added a commit that referenced this pull request Nov 14, 2018

Revert "Model ContainerNic refs under ContainerNicConfig as sub resou…
…rces" (#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)"

This reverts commit 633d12d.

* Revert "Port fix from PR 4459 to 2018-10-01 (#4463)"

This reverts commit 5ea0c7b.

* Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d9.

jianghaolu added a commit that referenced this pull request Nov 27, 2018

Network november release (#4509)
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* [Networkwatcer] add FlowLogFormatParameters (#4374)

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json

[Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties

* Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json"

This reverts commit f4f438a.

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json

[networkwatcer] add FlowLogFormatParameters

* [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420)

* Make NIC VM ref readonly (#4443)

* Mark private IP address read-only (#4447)

* change container nics property type on container nic config to resourceid (#4459)

* Port fix from PR 4459 to 2018-10-01 (#4463)

* Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* Adds Rewrite rule set for Header CRUD

Adds the structure of rewriteRuleSets in the applicationGatewayProperties.
Adds recursively the sub structures in the rewriteRuleSet.
Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule.

* Adds examples for the Header CRUD in application gateway

* Fix the examples; replacing rules with rewriteRules.

* Fixing the properties of application Gateway rewriteRule

* Revert "Fixing the properties of application Gateway rewriteRule"

This reverts commit 05c9c91.

* Fixing the properties of application Gateway rewriteRule

* Mark the provisioning state as readOnly

* Mark etag as readOnly

* Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)"

This reverts commit 633d12d.

* Revert "Port fix from PR 4459 to 2018-10-01 (#4463)"

This reverts commit 5ea0c7b.

* Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d9.

* Fixes the missing array for the header actions (#4497)

* Network py 2018-10

* add package-2018-10 to Go SDK codegen

* Application gateway Identity and Keyvault support (#4387)

* identity and keyvault

* Capitalization comment

* Ported fix from master branch (#4547)

jianghaolu added a commit that referenced this pull request Nov 27, 2018

Add support for List Operation on global reach connections (#4589)
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* [Networkwatcer] add FlowLogFormatParameters (#4374)

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json

[Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties

* Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json"

This reverts commit f4f438a.

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json

[networkwatcer] add FlowLogFormatParameters

* [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420)

* Make NIC VM ref readonly (#4443)

* Mark private IP address read-only (#4447)

* change container nics property type on container nic config to resourceid (#4459)

* Port fix from PR 4459 to 2018-10-01 (#4463)

* Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* Adds Rewrite rule set for Header CRUD

Adds the structure of rewriteRuleSets in the applicationGatewayProperties.
Adds recursively the sub structures in the rewriteRuleSet.
Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule.

* Adds examples for the Header CRUD in application gateway

* Fix the examples; replacing rules with rewriteRules.

* Fixing the properties of application Gateway rewriteRule

* Revert "Fixing the properties of application Gateway rewriteRule"

This reverts commit 05c9c91.

* Fixing the properties of application Gateway rewriteRule

* Mark the provisioning state as readOnly

* Mark etag as readOnly

* Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)"

This reverts commit 633d12d.

* Revert "Port fix from PR 4459 to 2018-10-01 (#4463)"

This reverts commit 5ea0c7b.

* Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d9.

* Fixes the missing array for the header actions (#4497)

* Network py 2018-10

* add package-2018-10 to Go SDK codegen

* Application gateway Identity and Keyvault support (#4387)

* identity and keyvault

* Capitalization comment

* Ported fix from master branch (#4547)

* Add support for list api for global reach connections

* address farhan comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.