Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing subAssessments type (Microsoft.Security provider) #6422

Open
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@orparnes
Copy link
Member

commented Jun 23, 2019

Latest improvements:

See also #5649 - Introducing assessments and assessmentsMetadata types

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.
@openapi-bot

This comment has been minimized.

Copy link

commented Jun 23, 2019

SDK Automation [Logs] (Generated from a20f3c0, Iteration 30)

Failed Go: Azure/azure-sdk-for-go [Logs]
  • No packages generated.
Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
Failed JavaScript: Azure/azure-sdk-for-js [Logs]
  • No packages generated.
@AutorestCI

This comment has been minimized.

Copy link

commented Jun 23, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpkjobgwdj/rest/specification/security/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpkjobgwdj/sdk/sdk', '--use=@microsoft.azure/autorest.python@~3.0.56', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4387/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4387)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0.56->3.0.62)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR: Syntax Error Encountered: Unexpected token } in JSON
    - file:///tmp/tmpkjobgwdj/rest/specification/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json:360:6

@azuresdkci

This comment has been minimized.

Copy link
Collaborator

commented Jun 23, 2019

Can one of the admins verify this patch?

@AutorestCI

This comment has been minimized.

Copy link

commented Jun 23, 2019

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpaie2clt9/rest/specification/security/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpaie2clt9/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.134', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4385/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4385)
   Including configuration file 'file:///tmp/tmpaie2clt9/rest/specification/security/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.134->2.1.134)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-composite-v1"} .
   Including configuration file 'file:///tmp/tmpaie2clt9/rest/specification/security/resource-manager/readme.go.md'
Processing batch task - {"tag":"package-composite-v2"} .
   Including configuration file 'file:///tmp/tmpaie2clt9/rest/specification/security/resource-manager/readme.go.md'
Processing batch task - {"tag":"package-composite-v3"} .
   Including configuration file 'file:///tmp/tmpaie2clt9/rest/specification/security/resource-manager/readme.go.md'
ERROR: Syntax Error Encountered: Unexpected token } in JSON
    - file:///tmp/tmpaie2clt9/rest/specification/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json:360:6

@AutorestCI

This comment has been minimized.

Copy link

commented Jun 23, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI

This comment has been minimized.

Copy link

commented Jun 23, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@orparnes orparnes force-pushed the orparnes:master branch from 3c016c9 to 5810c80 Jun 23, 2019

@orparnes orparnes force-pushed the orparnes:master branch 3 times, most recently from 2a437d4 to f9de390 Jun 24, 2019

@nschonni
Copy link
Contributor

left a comment

PS: Think there may be a "format" way to express the date. "format": "date-time"

@orparnes orparnes force-pushed the orparnes:master branch 2 times, most recently from b604b6b to 6e268a9 Jun 25, 2019

@orparnes orparnes force-pushed the orparnes:master branch from 6e268a9 to dc4dc68 Jun 25, 2019

@chlahav chlahav self-requested a review Jun 30, 2019

@orparnes orparnes force-pushed the orparnes:master branch from 40c48e7 to 8b65f23 Jun 30, 2019

Rename "extendedData" to "additionalData" to be aligned with "assessm…
…ent" type, fix examples, add field, edit status object

@orparnes orparnes force-pushed the orparnes:master branch from 8b65f23 to cd0227d Jun 30, 2019

@ravbhatnagar
Copy link
Collaborator

left a comment

@orparnes - please set up a 30 min call to close on this. Its not clear whether subassessment is the right model as a nested type. so need to understand the usecases a little better.

@orparnes orparnes force-pushed the orparnes:master branch from 88dee5a to 43468cc Jul 2, 2019

orparnes added some commits Jul 4, 2019

Resolve some issues, set spaces instead of tabs,
Add fields to ContainerRegistryVulnerabilityProperties and ServerVulnerabilityProperties

@orparnes orparnes force-pushed the orparnes:master branch from 7528fbd to b4e8dab Jul 14, 2019

@orparnes orparnes force-pushed the orparnes:master branch from 401ed18 to a20f3c0 Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.