Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create swagger for a new API: AutoDismissAlertsRules #7292

Open
wants to merge 6 commits into
base: master
from

Conversation

@yibirnba
Copy link
Contributor

yibirnba commented Sep 23, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.
yibirnba added 2 commits Jul 30, 2019
merge
@openapi-sdkautomation

This comment has been minimized.

Copy link

openapi-sdkautomation bot commented Sep 23, 2019

In Testing, Please Ignore

[Logs] (Generated from 0ec8710, Iteration 4)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress preview/security/mgmt/v1.0 [Logs]
  • In-Progress preview/security/mgmt/v2.0 [Logs]
  • In-Progress preview/security/mgmt/v3.0 [Logs]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
@azuresdkci

This comment has been minimized.

Copy link
Collaborator

azuresdkci commented Sep 23, 2019

Can one of the admins verify this patch?

@AutorestCI

This comment has been minimized.

Copy link

AutorestCI commented Sep 23, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8709

@AutorestCI

This comment has been minimized.

Copy link

AutorestCI commented Sep 23, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6452

"autoDismissAlertsScope": {
"allOf": [
{
"field": "CompromisedEntities",

This comment has been minimized.

Copy link
@yibirnba

yibirnba Sep 25, 2019

Author Contributor

Change to CompromisedEntity

Copy link
Collaborator

KrisBash left a comment

Signing off for ARM. Please see comment regarding enum option

"properties": {
"alertType": {
"type": "string",
"description": "Type of the auto dismissed alert. For all alert types, use '*'"

This comment has been minimized.

Copy link
@KrisBash

KrisBash Sep 26, 2019

Collaborator

Can this be an enum? If modelAsString=true, you can add values to this in a non-breaking fashion. Are the possible values finite?

This comment has been minimized.

Copy link
@yibirnba

yibirnba Oct 2, 2019

Author Contributor

The values are infinite , so it cannot be an enum

@sergey-shandar

This comment has been minimized.

Copy link
Member

sergey-shandar commented Oct 17, 2019

@chlahav is it still `DontMerge'?

yibirnba added 2 commits Oct 31, 2019
…into Azure-master

# Conflicts:
#	specification/security/resource-manager/readme.md
@yibirnba yibirnba force-pushed the yibirnba:master branch from a5c8e01 to a7e0568 Nov 28, 2019
Copy link
Member

orparnes left a comment

:shipit:

@yibirnba yibirnba force-pushed the yibirnba:master branch from 1ca919c to 45a0758 Dec 5, 2019
@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Dec 5, 2019

Pull request contains merge conflicts.
@yibirnba yibirnba force-pushed the yibirnba:master branch from 45a0758 to 4ff67e2 Dec 5, 2019
@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Dec 5, 2019

Pull request contains merge conflicts.
@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Dec 5, 2019

Comment was made before the most recent commit for PR 7292 in repo Azure/azure-rest-api-specs

@yibirnba yibirnba force-pushed the yibirnba:master branch from 29fc792 to 4ff67e2 Dec 5, 2019
@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Dec 5, 2019

Pull request contains merge conflicts.
@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Dec 5, 2019

Comment was made before the most recent commit for PR 7292 in repo Azure/azure-rest-api-specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.