Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azblob constructors should return clients by reference #16972

Closed
chlowell opened this issue Feb 3, 2022 · 1 comment
Closed

azblob constructors should return clients by reference #16972

chlowell opened this issue Feb 3, 2022 · 1 comment
Assignees
Labels
Client feature-request Storage

Comments

@chlowell
Copy link
Contributor

@chlowell chlowell commented Feb 3, 2022

That is to say, they should return a pointer to a client instance. They currently return an instance by value. For example:

func NewBlobClient(blobURL string, cred azcore.TokenCredential, options *ClientOptions) (BlobClient, error) {

@chlowell chlowell added Storage Client feature-request labels Feb 3, 2022
@mohsha-msft
Copy link
Member

@mohsha-msft mohsha-msft commented Apr 20, 2022

Hey @chlowell ,

azblob v0.4.0 is now publically available. I have made the necessary changes.

Thanks a lot for your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client feature-request Storage
Projects
None yet
Development

No branches or pull requests

3 participants