Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil pointer exception if nil options passed in ListBlobsFlat #17335

Closed
andrewbaxter opened this issue Mar 21, 2022 · 5 comments
Closed

Nil pointer exception if nil options passed in ListBlobsFlat #17335

andrewbaxter opened this issue Mar 21, 2022 · 5 comments
Assignees
Labels
bug Client customer-reported needs-team-attention Storage

Comments

@andrewbaxter
Copy link

@andrewbaxter andrewbaxter commented Mar 21, 2022

Bug Report

On azblob v0.3.0

The code was changed to reuse the passed in options for subsequent pagination requests here: #16992

However, if nil is passed in for options this causes a panic when the advancer tries to set the new marker. This conflicts with conventions elsewhere in the code that allow nil values to be passed in (and previously a nil value was also accepted here).

@msftbot msftbot bot added needs-triage customer-reported question labels Mar 21, 2022
@jhendrixMSFT jhendrixMSFT added the Storage label Mar 21, 2022
@msftbot msftbot bot removed the needs-triage label Mar 21, 2022
@jhendrixMSFT jhendrixMSFT added Client and removed question labels Mar 21, 2022
@msftbot msftbot bot added the needs-team-attention label Mar 21, 2022
@zezha-msft
Copy link
Member

@zezha-msft zezha-msft commented Mar 23, 2022

Thanks for reaching out!

We will take a look and make a fix in the next release.

@zezha-msft zezha-msft added the bug label Mar 23, 2022
@bcvanmeurs
Copy link

@bcvanmeurs bcvanmeurs commented Mar 24, 2022

I can confirm I encountered the same bug.

@mohsha-msft
Copy link
Member

@mohsha-msft mohsha-msft commented Mar 24, 2022

Hey @andrewbaxter , @bcvanmeurs ,

Thanks for reaching out!
I've fixed the issue and I'll ship it in the next release.

@bcvanmeurs
Copy link

@bcvanmeurs bcvanmeurs commented Mar 24, 2022

@mohsha-msft Great, thanks!

@mohsha-msft
Copy link
Member

@mohsha-msft mohsha-msft commented Apr 20, 2022

Hey @andrewbaxter @bcvanmeurs ,

azblob v0.4.0 is now publically available. I have fixed the issue here.

Please reach out and reopen the issue if it still persists.

Thanks a lot for your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Client customer-reported needs-team-attention Storage
Projects
None yet
Development

No branches or pull requests

5 participants