Blob breakLease proxy API signature incorrect #88

Closed
jcookems opened this Issue May 24, 2012 · 4 comments

Projects

None yet

3 participants

@jcookems
Contributor

Dev Estimate: 1
Test Estimate: 1

The current breakLease API is this:

public void breakLease(String container, String blob, String leaseId)

However, according to http://msdn.microsoft.com/en-us/library/windowsazure/ee691972,

x-ms-lease-action: <acquire | renew | release | break>
...
Break:
... the request is not required to specify a matching lease ID.
... the response indicates the interval in seconds until a new lease may be acquired.

This means that

  1. The leaseId parameter should be removed
  2. The function should return an object that includes a LeaseTime property.
gcheng commented Jul 10, 2012

We need to fix this for PHP as well!

@christav christav was assigned Feb 6, 2013
Contributor
christav commented Feb 6, 2013

Begun implementation. Parameter has been removed, need to add return value next.

Contributor
christav commented Feb 7, 2013

Added return value, waiting on code review.

Contributor
jcookems commented Feb 8, 2013

Looks good!

@jcookems jcookems closed this Feb 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment