[Ready for review] Added CDN Profiles to fluent #1257
Conversation
# Conflicts: # azure/src/main/java/com/microsoft/azure/management/Azure.java
hovsepm
changed the title
| Wrapper<EndpointInner> { | ||
|
|
||
| /** | ||
| * Get the originHostHeader value. |
There was a problem hiding this comment.
We use the 3rd person declarative mood for member descriptions, so "Gets" not "Get", "Specifies" not "Specify", etc.
pls scrub the Javadocs to get them consistent with that. thx
There was a problem hiding this comment.
Fixed everywhere in CDN public interfaces
| /** | ||
| * Get the originHostHeader value. | ||
| * | ||
| * @return the originHostHeader value |
There was a problem hiding this comment.
this is not a user-facing statement, as it is meaningless. i know this is the wording in the auto-gen'd one. We need to make it sound user-facing. i.e "origin host header" not "originHostHeader" value. pls scrub the javadocs with this in mind.
| /** | ||
| * Get the isHttpsAllowed value. | ||
| * | ||
| * @return the isHttpsAllowed value |
There was a problem hiding this comment.
for the Boolean, one descriptive way would be to say "true is HTTP is allowed, else false"
| Wrapper<EndpointInner> { | ||
|
|
||
| /** | ||
| * Get the originHostHeader value. |
There was a problem hiding this comment.
We use the 3rd person declarative mood for member descriptions, so "Gets" not "Get", "Specifies" not "Specify", etc.
pls scrub the Javadocs to get them consistent with that. thx
Btw - on parameters properties returning a value, we don't need the description, just the @return, so:
@return origin host header
| */ | ||
| interface PremiumEndpoint<ParentT> { | ||
| /** | ||
| * Specifies the Origin of the CDN Endpoint. |
There was a problem hiding this comment.
there is no need to capitalize "origin"
| } | ||
| } | ||
|
|
||
| /** The final stage of the CDN profile Standard Akamai or Standard Verizone endpoint definition. |
| WithStandardAttach<ParentT> withCustomDomain(String hostName); | ||
| } | ||
|
|
||
| /** The final stage of the CDN profile Premium Verizone endpoint definition. |
There was a problem hiding this comment.
pls correct all occurrences of the misspelled "Verizone"
| UpdateDefinitionStages.WithStandardAttach<ParentT> withOrigin(String originName, String originHostName); | ||
|
|
||
| /** | ||
| * Specifies the Origin of the CDN Endpoint. |
| * @param profileName Name of the CDN profile which is unique within the resource group. | ||
| * @param endpointName Name of the endpoint under the profile which is unique globally. | ||
| */ | ||
| void endpointStart(String resourceGroupName, String profileName, String endpointName); |
There was a problem hiding this comment.
method names that indicate action start with a verb, not noun --> startEndpoint()
| * @param profileName Name of the CDN profile which is unique within the resource group. | ||
| * @param endpointName Name of the endpoint under the profile which is unique globally. | ||
| */ | ||
| void endpointStop(String resourceGroupName, String profileName, String endpointName); |
| * @param endpointName Name of the endpoint under the profile which is unique globally. | ||
| * @param contentPaths The path to the content to be purged. Can describe a file path or a wild card directory. | ||
| */ | ||
| void endpointPurgeContent(String resourceGroupName, String profileName, String endpointName, List<String> contentPaths); |
| * @param endpointName Name of the endpoint under the profile which is unique globally. | ||
| * @param contentPaths The path to the content to be loaded. Should describe a file path. | ||
| */ | ||
| void endpointLoadContent(String resourceGroupName, String profileName, String endpointName, List<String> contentPaths); |
| @@ -0,0 +1,65 @@ | |||
| /** | |||
There was a problem hiding this comment.
in the future, pls do not include auto-gen'd code with hand-written code in the same PR. Makes full code reviews pretty much impossible :-)
|
Working on rebase to split generated and handcrafted files in two separate commits that will make code review easier... |
No description provided.