Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Code for Issues #301 & #112 #303

Closed
wants to merge 1 commit into from

2 participants

@BillAtPros

API returns HTTP Status Code 204 when Queue is empty. In this case
calling getValue() on the ReceiveQueueMessageResult will return null.

Changed ServiceBusRestProxy:receiveMessage() now returns a null BrokeredMessage from the getValue() call in cases where the REST call returns a 204 Status Code, which indicates the Queue is empty and remained empty until recieveMessage() call times out.

Tests added in ServiceBusIntegrationTest to test empty Queues in both Receive/Delete and Peek/Lock scenarios. Updated peekLockedMessageCanBeDeleted() to function with null BrokeredMessage returned in empty Queue scenario.

@BillAtPros BillAtPros Handle case where ServiceBus Queue is empty
API returns HTTP Status Code 204 when Queue is empty. In this case
calling getValue() on the ReceiveQueueMessageResult will return null.
f0391ea
@guangyang
Collaborator

Hi @BillAtPros

Thanks for sending us this PR. Could you please sign the CLA and send it to us following this instruction http://windowsazure.github.com/guidelines.html? After that, we will take a look at your PR.

Thanks again!

@BillAtPros

Waiting on my company's legal to approve the CLA. Will get it to you ASAP.

Also, apologies for commiting to master instead of dev branch.

@guangyang
Collaborator

Yeah, it should go with Dev. Could you please update the PR? Thanks.

@guangyang
Collaborator

@BillAtPros , we've received your CLA. Thanks. Could you please submit the PR to dev branch?

@BillAtPros
@BillAtPros

Working on it now. Have just done a fresh fork

@BillAtPros

Closed. Will issues new Pull Request from dev branch.

@BillAtPros BillAtPros closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 25, 2013
  1. @BillAtPros

    Handle case where ServiceBus Queue is empty

    BillAtPros authored
    API returns HTTP Status Code 204 when Queue is empty. In this case
    calling getValue() on the ReceiveQueueMessageResult will return null.
Something went wrong with that request. Please try again.