Code for Issues #301 & #112 #303

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

API returns HTTP Status Code 204 when Queue is empty. In this case
calling getValue() on the ReceiveQueueMessageResult will return null.

Changed ServiceBusRestProxy:receiveMessage() now returns a null BrokeredMessage from the getValue() call in cases where the REST call returns a 204 Status Code, which indicates the Queue is empty and remained empty until recieveMessage() call times out.

Tests added in ServiceBusIntegrationTest to test empty Queues in both Receive/Delete and Peek/Lock scenarios. Updated peekLockedMessageCanBeDeleted() to function with null BrokeredMessage returned in empty Queue scenario.

wdixon
Handle case where ServiceBus Queue is empty
API returns HTTP Status Code 204 when Queue is empty. In this case
calling getValue() on the ReceiveQueueMessageResult will return null.
Contributor

guangyang commented Mar 28, 2013

Hi @BillAtPros

Thanks for sending us this PR. Could you please sign the CLA and send it to us following this instruction http://windowsazure.github.com/guidelines.html? After that, we will take a look at your PR.

Thanks again!

Waiting on my company's legal to approve the CLA. Will get it to you ASAP.

Also, apologies for commiting to master instead of dev branch.

Contributor

guangyang commented Mar 29, 2013

Yeah, it should go with Dev. Could you please update the PR? Thanks.

Contributor

guangyang commented Apr 15, 2013

@BillAtPros , we've received your CLA. Thanks. Could you please submit the PR to dev branch?

From: Guang Yang [mailto:notifications@github.com]
Sent: Monday, April 15, 2013 4:46 PM
To: WindowsAzure/azure-sdk-for-java
Cc: William Dixon
Subject: Re: [azure-sdk-for-java] Code for Issues #301 & #112 (#303)

@billatproshttps://github.com/BillAtPros , we've received your CLA. Thanks. Could you please submit the PR to dev branch?


Reply to this email directly or view it on GitHubhttps://github.com/WindowsAzure/azure-sdk-for-java/pull/303#issuecomment-16413525.

Working on it now. Have just done a fresh fork

Closed. Will issues new Pull Request from dev branch.

@BillAtPros BillAtPros closed this Apr 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment