From 5dd56f57707de0e04d108dbc67e7688efeb699d4 Mon Sep 17 00:00:00 2001
From: Daniel Jurek <djurek@microsoft.com>
Date: Thu, 10 Aug 2023 11:51:18 -0700
Subject: [PATCH] Add skipPublishDocMs to false error reports in docs
 heuristics (#26773)

Example pipeline fixed by this change:

* Identity --
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2995011&view=results
* Core --
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2995180&view=logs&j=f8e040b3-c0ff-5789-0eda-99daaaa3fc1b&t=f8e040b3-c0ff-5789-0eda-99daaaa3fc1b

Work item to undo this when we integrate `@microsoft/type2docfx`
https://github.com/Azure/azure-sdk-for-js/issues/26770
---
 eng/pipelines/templates/stages/archetype-js-release.yml | 3 ++-
 eng/scripts/validate-docs-package.ps1                   | 1 -
 sdk/core/ci.yml                                         | 2 ++
 sdk/identity/ci.yml                                     | 4 ++++
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/eng/pipelines/templates/stages/archetype-js-release.yml b/eng/pipelines/templates/stages/archetype-js-release.yml
index 02c002d3992c..1289798d589b 100644
--- a/eng/pipelines/templates/stages/archetype-js-release.yml
+++ b/eng/pipelines/templates/stages/archetype-js-release.yml
@@ -307,7 +307,8 @@ stages:
           parameters:
             PackageInfoLocations:
               - ${{ each artifact in parameters.Artifacts }}:
-                - $(Pipeline.Workspace)/${{parameters.ArtifactName}}/PackageInfo/${{artifact.name}}.json
+                - ${{if ne(artifact.skipPublishDocMs, 'true')}}:
+                  - $(Pipeline.Workspace)/${{parameters.ArtifactName}}/PackageInfo/${{artifact.name}}.json
             RepoId: Azure/azure-sdk-for-js
             WorkingDirectory: $(System.DefaultWorkingDirectory)
             TargetDocRepoOwner: ${{parameters.TargetDocRepoOwner}}
diff --git a/eng/scripts/validate-docs-package.ps1 b/eng/scripts/validate-docs-package.ps1
index 0283684e9bc1..854c0b9a31e8 100644
--- a/eng/scripts/validate-docs-package.ps1
+++ b/eng/scripts/validate-docs-package.ps1
@@ -82,7 +82,6 @@ function DockerValidation() {
   return GetResult $true $Package $installOutput
 }
 
-
 if (!$DocValidationImageId) {
   FallbackValidation
 } 
diff --git a/sdk/core/ci.yml b/sdk/core/ci.yml
index abf5389f4ee1..6f6c2bbcefc9 100644
--- a/sdk/core/ci.yml
+++ b/sdk/core/ci.yml
@@ -52,6 +52,8 @@ extends:
         safeName: azurecorehttp
       - name: azure-core-rest-pipeline
         safeName: azurecorerestpipeline
+        # TODO: Remove when REX validation tool is integrated: https://github.com/Azure/azure-sdk-for-js/issues/26770
+        skipPublishDocMs: true
       - name: azure-core-lro
         safeName: azurecorelro
       - name: azure-core-paging
diff --git a/sdk/identity/ci.yml b/sdk/identity/ci.yml
index 855f8e9c53e6..f802c19862a2 100644
--- a/sdk/identity/ci.yml
+++ b/sdk/identity/ci.yml
@@ -30,5 +30,9 @@ extends:
         safeName: azureidentity
       - name: azure-identity-cache-persistence
         safeName: azureidentitycachepersistence
+        # TODO: Remove when REX validation tool is integrated: https://github.com/Azure/azure-sdk-for-js/issues/26770
+        skipPublishDocMs: true
       - name: azure-identity-vscode
         safeName: azureidentityvscode
+        # TODO: Remove when REX validation tool is integrated: https://github.com/Azure/azure-sdk-for-js/issues/26770
+        skipPublishDocMs: true