Update node versions in CI matrix

[xirzec]

Bumping out matrix to test up to Node 18 (latest) instead of the unstable Node 17.

Also removing Node 12 from the bottom in anticipation of our deprecating support for it after the October release.

[mikeharder]

I agree with updating v17 to v18. I would wait to remove v12 until our support officially ends.

[jeremymeng]

Our support policy mentions 6-month after a NodeJS version reaches End of Life status. Node v12 EOL is 04/30/2022 so we are close.

@xirzec there are a couple other places where "NodeTestVersion": "12.x" is used, should those be bumped to 14.x?

[xirzec]

@mikeharder my thinking was we're already code complete for the last version of our SDKs that will support v12, so we can hold off on merging until after they ship but really there's very little chance we're going to do anything that's 12 specific at this point.

@jeremymeng the only other spot I saw it was in some commented out config - are you seeing it still used somewhere?

[jeremymeng]

@xirzec some packages have their own platform-matrix.json

sdk/communication/communication-phone-numbers/phone-numbers-livetest-matrix.json:24:    "NodeTestVersion": ["12.x", "14.x", "16.x", "17.x"],
sdk/communication/communication-phone-numbers/phone-numbers-livetest-matrix.json:56:      "NodeTestVersion": "12.x"
sdk/communication/communication-phone-numbers/phone-numbers-livetest-matrix.json:66:      "NodeTestVersion": "12.x",
sdk/keyvault/keyvault-admin/platform-matrix.json:13:          "NodeTestVersion": "12.x"
sdk/keyvault/keyvault-keys/platform-matrix.json:12:      "NodeTestVersion": "12.x"

[azure-sdk]

API change check

API changes are not detected in this pull request.

[mikeharder]

Revert whitespace changes

[xirzec]

dang prettier making this harder than it needs to be. 😄

[mikeharder]

If you are using VS Code, they have a saveWithoutFormatting command that's helpful in these cases: https://stackoverflow.com/a/71423157/3630403

[xirzec]

super handy!

[mikeharder]

Revert formatting changes