Consume snippet generator as a tool #22783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
2 times, most recently
from
d05287c to
fc2f5b8
Compare
weshaggard
reviewed
Jul 26, 2021
weshaggard
reviewed
Jul 26, 2021
weshaggard
reviewed
Jul 26, 2021
weshaggard
reviewed
Jul 26, 2021
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
2 times, most recently
from
5df80d4 to
e9c0f98
Compare
weshaggard
reviewed
Jul 27, 2021
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
from
e9c0f98 to
04fc71b
Compare
weshaggard
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
As we chatted I like that this is a tool now but there is still some risk of a race condition from installing the tool globally but I think that risk is minimal compared to compiling the project.
We might want to potentially consider pinning the version instead of using a * version on the install.
Another thing to consider is I suspect that we are running these codechecks multiple times for each service directory, once per project, so we are likely doing more work then we need to but as long as the work doesn't take too long it probably doesn't matter.
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
7 times, most recently
from
7cafc59 to
249fb97
Compare
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
3 times, most recently
from
207f50e to
23f807f
Compare
…ools package from azure-sdk-tools DevOps feed Remove eng\snippetgenerator Update Update-Snippets.ps1 to consuem Snippet Generator tyools package from azure-sdk-tools DevOps feed
…ly as source in Update-Snippets.ps1
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
from
23f807f to
aec44d2
Compare
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
2 times, most recently
from
7ed15fb to
4526e50
Compare
chidozieononiwu
force-pushed
the
ConsumeSnippetGeneratorAsATool
branch
from
4526e50 to
b21d1ac
Compare
chidozieononiwu
added a commit
that referenced
this pull request
Aug 31, 2021
This reverts commit e618fb8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.