Fix model factory parameter naming: change `eTag` to `etag` for acronym compliance #53477

Copilot · 2025-10-24T07:39:28Z

Model Factory Parameter Naming Fix: `eTag` → `etag`

Problem

Model factory methods in Azure Management SDKs were generating parameter names that don't follow .NET naming conventions for acronyms. Specifically, the ETag property was being converted to eTag instead of the correct etag in camelCase parameter names.

Solution

Implemented a property-to-parameter name mapping in ModelFactoryVisitor.cs that specifically handles the ETag property case:

Added a static dictionary mapping "ETag" property name to "etag" parameter name
When processing model factory methods, the visitor checks each parameter's associated property
If the property name matches an entry in the dictionary and the parameter name differs, the parameter is updated
XML documentation is automatically refreshed by updating the method signature
This approach allows for precise control over specific property-to-parameter name mappings

Changes Made

Test Verification

Added Azure.Core.eTag property (lowercase) to the Mgmt-TypeSpec test project. The generated model factory now correctly shows:

/// <param name="etag"> ETag property for testing etag parameter name generation. </param>
public static FooData FooData(..., ETag? etag = default)

Files Modified

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/ModelFactoryVisitor.cs - Added parameter name mapping logic with optimized update check
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/foo.tsp - Added etag property (lowercase) for testing
Generated test files updated to demonstrate the fix
Merged latest changes from main branch

Fixes #53476

Original prompt

This section details on the original issue you should resolve

<issue_title>model factory parameter should use etag instead of eTag</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #53476

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

…eter Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

...registry/Azure.ResourceManager.DeviceRegistry/src/Generated/ArmDeviceRegistryModelFactory.cs

...tp-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/StringExtensions.cs

…st property - Revert StringExtensions.cs changes as requested - Revert ArmDeviceRegistryModelFactory.cs manual changes - Implement ETag parameter name mapping in ModelFactoryVisitor.cs using a dictionary - Add ETag property to Mgmt-TypeSpec test project to verify the fix - Remove StringExtensionsTests.cs as it's no longer needed - Regenerate test project showing etag parameter working correctly Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

...-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/ModelFactoryVisitor.cs

live1206 · 2025-10-27T03:13:18Z

@copilot merge from latest main branch, resolve the conflict and regenerate the test code

- Instead of manually constructing XmlDocParamStatement objects, use method.Update(signature: method.Signature) to refresh documentation - This is the same pattern used in NameVisitor.cs and is cleaner/simpler - All tests pass (60/60) and generated code still correctly shows etag parameter Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

…tory-etag-parameter # Conflicts: # eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/tspCodeModel.json

- Merged latest main branch into the PR branch - Resolved merge conflict in tspCodeModel.json - Regenerated test project to ensure compatibility - All generator tests pass (60/60) - Fix verified: etag parameter still correctly generated Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

Copilot · 2025-10-27T03:27:52Z

@copilot merge from latest main branch, resolve the conflict and regenerate the test code

Done. Merged from latest main branch, resolved the tspCodeModel.json conflict, and regenerated the test code. All tests pass (60/60) and the etag parameter fix is still working correctly. (commits d095981 and 4daefd3)

eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/foo.tsp

- Changed property name in foo.tsp from eTag to etag (lowercase) - Regenerated test project with updated property name - Model factory still correctly generates etag parameter (lowercase) - All generator tests pass (60/60) Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

Copilot

Pull Request Overview

This PR fixes model factory parameter naming to comply with .NET acronym conventions by changing eTag to etag in camelCase parameter names. The solution implements a property-to-parameter name mapping in ModelFactoryVisitor.cs that specifically handles the ETag property case, ensuring the generated parameter name follows the correct convention.

Key Changes:

Added dictionary-based property-to-parameter name mapping in ModelFactoryVisitor
Added test case with lowercase etag property in TypeSpec test project
Method signature update automatically refreshes XML documentation

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated 1 comment.

File	Description
ModelFactoryVisitor.cs	Implements property-to-parameter name mapping with dictionary and parameter name update logic
foo.tsp	Adds lowercase `etag` property to test the parameter name generation

...-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/ModelFactoryVisitor.cs

- Added check to compare parameter.Name with newName before updating - Combined the property check, dictionary lookup, and name comparison into a single if condition - Avoids unnecessary parameter updates when the name is already correct - All tests pass (60/60) and generated code verified Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

...csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/FooProperties.cs

live1206 · 2025-10-28T03:15:48Z

/check-enforcer override

live1206 · 2025-10-29T08:48:23Z

@copilot Merge from latest main and regenerate test

…tory-etag-parameter # Conflicts: # eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/tspCodeModel.json

- Merged latest main branch into the PR branch - Resolved merge conflict in tspCodeModel.json - Regenerated test project to ensure compatibility - All generator tests pass (60/60) - Fix verified: etag parameter still correctly generated Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

Copilot · 2025-10-29T08:55:48Z

@copilot Merge from latest main and regenerate test

Done. Merged from latest main branch, resolved the tspCodeModel.json conflict, and regenerated the test. All tests pass (60/60) and the etag parameter fix is still working correctly. (commits 36a5ed1 and 4d52e45)

live1206 · 2025-10-29T09:15:57Z

/check-enforcer override

Initial plan

c783efa

Copilot AI assigned Copilot and live1206 Oct 24, 2025

Copilot started work on behalf of live1206 October 24, 2025 07:40 View session

Copilot AI and others added 2 commits October 24, 2025 08:05

Fix FirstCharToLowerCase to properly handle acronyms in parameter names

ca034f2

Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

Apply generator fix to DeviceRegistry SDK - change eTag to etag param…

7af2765

…eter Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix model factory parameter to use etag instead of eTag~~ Fix model factory parameter naming: change eTag to etag for acronym compliance Oct 24, 2025

Copilot AI requested a review from live1206 October 24, 2025 08:12

Copilot finished work on behalf of live1206 October 24, 2025 08:12

live1206 reviewed Oct 27, 2025

View reviewed changes

...registry/Azure.ResourceManager.DeviceRegistry/src/Generated/ArmDeviceRegistryModelFactory.cs Outdated Show resolved Hide resolved

...tp-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/StringExtensions.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of live1206 October 27, 2025 02:47 View session

Copilot finished work on behalf of live1206 October 27, 2025 03:06

Copilot AI requested a review from live1206 October 27, 2025 03:06

live1206 reviewed Oct 27, 2025

View reviewed changes

...-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/ModelFactoryVisitor.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of live1206 October 27, 2025 03:12 View session

Copilot AI requested a review from live1206 October 27, 2025 03:19

Copilot finished work on behalf of live1206 October 27, 2025 03:19

Copilot started work on behalf of live1206 October 27, 2025 03:20 View session

Copilot AI and others added 2 commits October 27, 2025 03:23

Merge remote-tracking branch 'origin/main' into copilot/fix-model-fac…

d09581f

…tory-etag-parameter # Conflicts: # eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/tspCodeModel.json

Copilot finished work on behalf of live1206 October 27, 2025 03:28

live1206 reviewed Oct 27, 2025

View reviewed changes

eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/foo.tsp Outdated Show resolved Hide resolved

Copilot started work on behalf of live1206 October 27, 2025 06:11 View session

Copilot AI requested a review from live1206 October 27, 2025 06:18

Copilot finished work on behalf of live1206 October 27, 2025 06:18

live1206 marked this pull request as ready for review October 27, 2025 06:23

live1206 requested review from JoshLove-msft, jorgerangel-msft and m-nash as code owners October 27, 2025 06:23

Copilot AI review requested due to automatic review settings October 27, 2025 06:23

live1206 requested a review from ArcturusZhang as a code owner October 27, 2025 06:23

Copilot AI reviewed Oct 27, 2025

View reviewed changes

...-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/ModelFactoryVisitor.cs Show resolved Hide resolved

Copilot started work on behalf of live1206 October 27, 2025 06:46 View session

Copilot finished work on behalf of live1206 October 27, 2025 06:53

ArcturusZhang reviewed Oct 28, 2025

View reviewed changes

...csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/FooProperties.cs Show resolved Hide resolved

ArcturusZhang approved these changes Oct 28, 2025

View reviewed changes

ArthurMa1978 approved these changes Oct 29, 2025

View reviewed changes

Copilot started work on behalf of live1206 October 29, 2025 08:48 View session

Copilot AI and others added 2 commits October 29, 2025 08:51

Merge remote-tracking branch 'origin/main' into copilot/fix-model-fac…

36a5ed1

…tory-etag-parameter # Conflicts: # eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/tspCodeModel.json

Copilot finished work on behalf of live1206 October 29, 2025 08:57

ArthurMa1978 approved these changes Oct 29, 2025

View reviewed changes

live1206 enabled auto-merge (squash) October 29, 2025 09:16

ArcturusZhang approved these changes Oct 29, 2025

View reviewed changes

live1206 merged commit 1962463 into main Oct 29, 2025
22 checks passed

live1206 deleted the copilot/fix-model-factory-etag-parameter branch October 29, 2025 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix model factory parameter naming: change `eTag` to `etag` for acronym compliance #53477

Fix model factory parameter naming: change `eTag` to `etag` for acronym compliance #53477

Uh oh!

Copilot AI commented Oct 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

live1206 commented Oct 27, 2025

Uh oh!

Copilot AI commented Oct 27, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

live1206 commented Oct 28, 2025

Uh oh!

live1206 commented Oct 29, 2025

Uh oh!

Copilot AI commented Oct 29, 2025

Uh oh!

live1206 commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix model factory parameter naming: change eTag to etag for acronym compliance #53477

Fix model factory parameter naming: change eTag to etag for acronym compliance #53477

Uh oh!

Conversation

Copilot AI commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Model Factory Parameter Naming Fix: eTag → etag

Problem

Solution

Changes Made

Test Verification

Files Modified

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

live1206 commented Oct 27, 2025

Uh oh!

Copilot AI commented Oct 27, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

live1206 commented Oct 28, 2025

Uh oh!

live1206 commented Oct 29, 2025

Uh oh!

Copilot AI commented Oct 29, 2025

Uh oh!

live1206 commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix model factory parameter naming: change `eTag` to `etag` for acronym compliance #53477

Fix model factory parameter naming: change `eTag` to `etag` for acronym compliance #53477

Copilot AI commented Oct 24, 2025 •

edited

Loading

Model Factory Parameter Naming Fix: `eTag` → `etag`