Permalink
Browse files

Applying more code review comments

  • Loading branch information...
1 parent d18853b commit 2981980e800bc87734ee61cb864661a2d5812e26 Andre Rodrigues committed Oct 23, 2012
Showing with 3 additions and 3 deletions.
  1. +3 −3 lib/cli/linkedrevisioncontrol_.js
@@ -240,7 +240,7 @@ GithubClient.prototype.getRepositories = function (username, _) {
var progress = this.cli.progress('Retrieving repositories');
var userRepos = [];
- function sortFunction (repositoryA, repositoryB) {
+ function sortByFullName (repositoryA, repositoryB) {
return repositoryA.full_name.toLowerCase()
.localeCompare(repositoryB.full_name.toLowerCase());
};
@@ -252,7 +252,7 @@ GithubClient.prototype.getRepositories = function (username, _) {
try {
userRepos = this.client.repos.getFromUser({ user: username }, _)
.filter(filterPrivate)
- .sort(sortFunction);
+ .sort(sortByFullName);
var orgs = this.client.orgs.getFromUser({ user: username }, _);
if (orgs) {
@@ -268,7 +268,7 @@ GithubClient.prototype.getRepositories = function (username, _) {
}
}
}
- orgRepos = orgRepos.filter(filterPrivate).sort(sortFunction);
+ orgRepos = orgRepos.filter(filterPrivate).sort(sortByFullName);
userRepos = userRepos.concat(orgRepos);
} finally {

0 comments on commit 2981980

Please sign in to comment.