Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Applying CR comments.

  • Loading branch information...
commit 340ea70f48840821b113046423d322f23eda5705 1 parent 08804f2
@andrerod andrerod authored
View
20 lib/services/core/servicebussettings.js
@@ -25,9 +25,9 @@ var Validate = require('../../util/validate');
exports = module.exports = ServiceBusSettings;
-var _serviceBusEndpointSetting = ServiceSettings.settingWithFunc(ConnectionStringKeys.SERVICE_BUS_ENDPOINT_NAME, Validate.getIsValidUri());
-var _wrapNameSetting = ServiceSettings.setting(ConnectionStringKeys.SHARED_SECRET_ISSUER_NAME);
-var _wrapPasswordSetting = ServiceSettings.setting(ConnectionStringKeys.SHARED_SECRET_VALUE_NAME);
+var serviceBusEndpointSetting = ServiceSettings.settingWithFunc(ConnectionStringKeys.SERVICE_BUS_ENDPOINT_NAME, Validate.getIsValidUri());
+var wrapNameSetting = ServiceSettings.setting(ConnectionStringKeys.SHARED_SECRET_ISSUER_NAME);
+var wrapPasswordSetting = ServiceSettings.setting(ConnectionStringKeys.SHARED_SECRET_VALUE_NAME);
var validKeys = [
ConnectionStringKeys.SERVICE_BUS_ENDPOINT_NAME,
@@ -64,9 +64,9 @@ ServiceBusSettings.createFromConnectionString = function (connectionString) {
var matchedSpecs = ServiceSettings.matchedSpecification(
tokenizedSettings,
ServiceSettings.allRequired(
- _serviceBusEndpointSetting,
- _wrapNameSetting,
- _wrapPasswordSetting
+ serviceBusEndpointSetting,
+ wrapNameSetting,
+ wrapPasswordSetting
)
);
@@ -81,13 +81,13 @@ ServiceBusSettings.createFromConnectionString = function (connectionString) {
var namespace = parsedUrl.host.split('.')[0];
var issuerName = util.tryGetValueInsensitive(
- ConnectionStringKeys.SHARED_SECRET_ISSUER_NAME,
- tokenizedSettings
+ ConnectionStringKeys.SHARED_SECRET_ISSUER_NAME,
+ tokenizedSettings
);
var issuerValue = util.tryGetValueInsensitive(
- ConnectionStringKeys.SHARED_SECRET_VALUE_NAME,
- tokenizedSettings
+ ConnectionStringKeys.SHARED_SECRET_VALUE_NAME,
+ tokenizedSettings
);
return new ServiceBusSettings(
View
12 lib/services/core/servicemanagementsettings.js
@@ -25,16 +25,16 @@ var Validate = require('../../util/validate');
exports = module.exports = ServiceManagementSettings;
-var _endpointSetting = ServiceSettings.settingWithFunc(
+var endpointSetting = ServiceSettings.settingWithFunc(
ConnectionStringKeys.SERVICE_MANAGEMENT_ENDPOINT_NAME,
Validate.getIsValidUri()
);
-var _certificatePathSetting = ServiceSettings.setting(
+var certificatePathSetting = ServiceSettings.setting(
ConnectionStringKeys.CERTIFICATE_PATH_NAME
);
-var _subscriptionIdSetting = ServiceSettings.setting(
+var subscriptionIdSetting = ServiceSettings.setting(
ConnectionStringKeys.SUBSCRIPTION_ID_NAME
);
@@ -70,11 +70,11 @@ ServiceManagementSettings.createFromConnectionString = function (connectionStrin
var matchedSpecs = ServiceSettings.matchedSpecification(
tokenizedSettings,
ServiceSettings.allRequired(
- _subscriptionIdSetting,
- _certificatePathSetting
+ subscriptionIdSetting,
+ certificatePathSetting
),
ServiceSettings.optional(
- _endpointSetting
+ endpointSetting
)
);
Please sign in to comment.
Something went wrong with that request. Please try again.