This repository has been archived by the owner on May 5, 2023. It is now read-only.
Deserialization autogenerated client and related tests for basic data ty... #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| done(); | ||
| }); | ||
|
|
||
| test('GetBoolNullable with a null elemet should deserialize into null', function (done) { |
There was a problem hiding this comment.
refer to bug #1165
|
Great job, Amar! Some issues noted. We should consider whether to move the visual studio generation architecture here in the long term - we should really be consuming the spec and generating whenever there are changes made to hydra or the node library. |
| suite('array-datatype-deserialization-tests', function () { | ||
| var baseUri = 'http://helloworld'; | ||
| var subscriptionId = "c9cbd920-c00c-427c-852b-8aaf38badaeb"; | ||
| var pemfile = process.env.AZURE_CERTIFICATE_PEM_FILE; |
There was a problem hiding this comment.
Do we really need an actual pem file? None of these go out over the wire, can we just mock/fake this?
| test('GetPrimitiveSequence with valid primitive values should deserialize properly', function (done) { | ||
| nock("http://helloworld") | ||
| .get("/GetPrimitiveSequence") | ||
| .reply(200, "<LIST><STRING>Hello world</STRING><STRING>Hurray!!</STRING></LIST>"); |
There was a problem hiding this comment.
Use lowercase/camelcase here, not all caps.
|
@amarzavery coudl you apply the review comments so that we can merge this in ? Thanks, |
|
@amarzavery : ping ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...pes