fix entity group transactions with delete commands: don't send a content-type header for thse #300

Merged
merged 1 commit into from Aug 14, 2012

Conversation

Projects
None yet
3 participants
Contributor

smarx commented Aug 7, 2012

Entity group transactions containing delete operations fail, and it appears to be because there's a content-type header (despite there being no content).

Also note that the original code referred to properties that don't seem to exist (ServiceClient.HTTP_VERB_*), so I just put the string constants in there instead ('GET' and 'DELETE').

On a side-note, it's probably wrong to include the content-length on a delete, but that didn't seem to cause an error, so I didn't touch that. This seemed to me to be close to the minimal change necessary to fix the bug.

andrerod commented Aug 7, 2012

Hi Steve,

Do you remember if you ever send us a CLA agreement ? I just asked yavor but still waiting for confirmation ...

This one:
http://windowsazure.github.com/guidelines.html

Thanks,
Andre

Contributor

smarx commented Aug 7, 2012

I have not signed it. I'll take a look, but I don't like signing things that don't benefit me... :-) Assuming I don't want to sign it, should I just file a bug and let you fix it on your own instead?

andrerod commented Aug 8, 2012

Yup. That'd be the alternative.

andrerod commented Aug 8, 2012

The benefit for you would be being able to streamline any contribution from you for this or other MSFT projects rather than waiting for product teams to act on it ... Up to you if you see that as an advantage... We understand that the CLA is not ideal but ...

Contributor

yavorg commented Aug 13, 2012

Thanks Steve - please consider signing the CLA. For GitHub glory...

Contributor

smarx commented Aug 13, 2012

Just signed and mailed to cla@microsoft.com.

On Mon, Aug 13, 2012 at 11:09 AM, Yavor Georgiev
notifications@github.comwrote:

Thanks Steve - please consider signing the CLA. For GitHub glory...


Reply to this email directly or view it on GitHubhttps://github.com/WindowsAzure/azure-sdk-for-node/pull/300#issuecomment-7701090.

Contributor

yavorg commented Aug 13, 2012

You're approved. Welcome to the gang.

@andrerod andrerod pushed a commit that referenced this pull request Aug 14, 2012

André Rodrigues Merge pull request #300 from smarx/dev
fix entity group transactions with delete commands: don't send a content-type header for thse
d3fd9ed

@andrerod andrerod merged commit d3fd9ed into Azure:dev Aug 14, 2012

Thanks Steve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment