Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bugfixes #415

Merged
merged 6 commits into from Oct 29, 2012

Conversation

Projects
None yet
2 participants

No description provided.

@ogail ogail commented on the diff Oct 29, 2012

lib/cli/commands/deployment.js
@@ -169,7 +169,7 @@ exports.init = function(cli) {
- scm.command("github [name]").whiteListPowershell().usage("[options] [name]").description("Links a website to a github account for deployment").option("-s, --subscription <id>", "use the subscription id").option("-u, --username <user>", "The github username").option("-up, --pass <pass>", "The github password").option("-r, --repository <repository>", "The github repository full name (i.e. user/repository)").execute(function __4(name, options, _) { var context;
+ scm.command("github [name]").whiteListPowershell().usage("[options] [name]").description("Links a website to a github account for deployment").option("-s, --subscription <id>", "use the subscription id").option("--githubusername <username>", "The github username").option("--githubpassword <password>", "The github password").option("--githubrepository <repository>", "The github repository full name (i.e. user/repository)").execute(function __4(name, options, _) { var context;
@ogail

ogail Oct 29, 2012

Nit: line is too long, it'd be good if line is around 120 chrs so no need to scroll deep to the right

@andrerod

andrerod Oct 29, 2012

This is autogenerated.

@ogail ogail commented on the diff Oct 29, 2012

lib/cli/commands/deployment_.js
@@ -174,9 +174,9 @@ exports.init = function (cli) {
.usage('[options] [name]')
.description('Links a website to a github account for deployment')
.option('-s, --subscription <id>', 'use the subscription id')
- .option('-u, --username <user>', 'The github username')
- .option('-up, --pass <pass>', 'The github password')
- .option('-r, --repository <repository>', 'The github repository full name (i.e. user/repository)')
+ .option('--githubusername <username>', 'The github username')
@ogail

ogail Oct 29, 2012

Is there's a way to centralize the parameter changes so when u change parameter that affects all subsequent places?

@andrerod

andrerod Oct 29, 2012

Not really applicable for this. Would break the usual styling etc... Rather keep it as is.

ogail commented Oct 29, 2012

LGTM

andrerod pushed a commit that referenced this pull request Oct 29, 2012

@andrerod andrerod merged commit b91e6b5 into Azure:dev Oct 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment