Adding support for creating and deleting affinity groups #539

Closed
wants to merge 1 commit into from

3 participants

@fkjellberg

This pull request adds support for more affinity group API calls in the SDK. I'll make another pull request for the front-end CLI code.

@fkjellberg fkjellberg referenced this pull request in Azure/azure-xplat-cli Dec 27, 2012
Closed

Adding support for creating and deleting affinity groups #174

@glennblock

Hi @fkjellberg ,

Thanks for sending us this PR!

Please check out our guidelines at http://windowsazure.github.com/guidelines.html and fill out the Contributor License Agreement (http://windowsazure.github.com/docs/Contribution%20License%20Agreement.pdf) and email it to cla@microsoft.com so we can get this merged!

Thanks,
Glenn

@fkjellberg

Hi @glennblock

Thanks for reviewing and accepting the PR! I'll get the paperwork done within a few days.

/Fredrik

@fkjellberg

@glennblock Paperwork done!

/Fredrik

@andrerod

@fkjeliberg: Your change looks great! But could you please add a few UT to it ? You can see examples in the project. Thanks in advance

@andrerod

Also, one detail: could you do your PR to the dev branch instead of the master branch ? We use the master branch to keep track of the latest release, while dev contains the most up to date code. Contributions usually go to dev so that the team has an opportunity of reviewing / testing it before incorporating in the public release. We iterate pretty fast, so you'll usually see your changes in the next version (typically 2 / 3 weeks)

@fkjellberg

@andrerod Sorry about not using the dev branch. I didn't find out that the main development was done on the dev branch until after sending the pull request. I'll create a new branch from the dev branch and redo the changes there.

I'll also add unit tests for the new functionality before sending a new pull request (or can I update this pull request from another branch?)

@andrerod

I think you actually need a new PR... :( Sorry. LMK once u're ready and we'll take your changes in. :) Thanks so much for contributing

@glennblock

@fkjellberg we got your CLA and you are approved now. Sorry for the delay!

@fkjellberg

I've replaced this PR with #569 so I'm closing this one now.

@fkjellberg fkjellberg closed this Feb 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment