#499: Make generating blob URL with SAS easier #564

Merged
merged 4 commits into from Jan 30, 2013

Conversation

Projects
None yet
2 participants

No description provided.

* @return {object} An object with the blob URL.
*/
-BlobService.prototype.getBlobUrl = function (container, blob) {
+BlobService.prototype.getBlobUrl = function (container, blob, sharedAccessPolicy) {
@christav

christav Jan 29, 2013

Contributor

parameter in doc comments is named sharedAccessPermissions, here it's sharedAccessPolicy

+var testutil = require('./util');
+var azure = testutil.libRequire('azure');
+
+suite('date-tests', function () {
@christav

christav Jan 29, 2013

Contributor

There are a ton of potential corner cases here, particularly around daylight savings time and shifts. What should happen when the date util runs on the switchover, you add an hour, but the clock also moves back an hour?

May not be an issue, but this exact problem brought azure down for many hours not that long ago.

+* @param {int} days The days timespan.
+* @return {Date}
+*/
+exports.daysFromNow = function (days) {
@christav

christav Jan 29, 2013

Contributor

Watch out for daylight savings time switch points - there's a ton of corner cases here that could cause problems.

@andrerod

andrerod Jan 30, 2013

As we discussed in person, this should be fine as long as the Timezone is kept in picture and respected.

Noticed i had incorrectly add this in the previous commit. removing it here.

The require and call to process.platform should be done once at the top of the file and the results stored for later use.

Owner

andrerod replied Jan 30, 2013

I suspect that wont actually make a difference for most cases, but ok.

andrerod pushed a commit that referenced this pull request Jan 30, 2013

Merge pull request #564 from andrerod/dev
#499: Make generating blob URL with SAS easier

@andrerod andrerod merged commit 2712ccb into Azure:dev Jan 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment