Permalink
Browse files

Apply code review

  • Loading branch information...
1 parent 4b2ffb6 commit 049e14db8136495d200b898b6024da86f50a64b8 Abdelrahman Elogeel committed May 31, 2012
Showing with 57 additions and 40 deletions.
  1. +34 −20 package.php
  2. +23 −20 package.xml
View
@@ -23,21 +23,36 @@
require_once 'PEAR/PackageFileManager2.php';
PEAR::setErrorHandling(PEAR_ERROR_DIE);
-$package = 'WindowsAzure';
-$channel = 'pear.windowsazure.com';
-$summary = '
-Summary for Windows Azure SDK for PHP
+$package = 'WindowsAzure';
+$channel = 'pear.blob.core.windows.net';
+$release_version = '0.1.0';
+$api_version = '0.1.0';
+$release_state = 'beta';
+$api_state = 'beta';
+$min_php_version = '5.3.0';
+$min_pear_version = '1.8.0';
+$license = 'Apache 2.0';
+$license_agreement = 'http://www.apache.org/licenses/LICENSE-2.0';
+$summary = '
+Official PHP SDK for Microsoft Windows Azure.
';
-$description = '
-Description for Windows Azure SDK for PHP
+$description = '
+The Windows Azure client libraries provide easy access to all Windows Azure REST services
+including Tables, Blobs, Queues, Service Bus, Service Management and Service Runtime.
';
-$release_version = '1.0.0';
-$release_state = 'stable';
-$release_notes = '
-* Full support of Windows Azure sotrage services Queue, Blob and Table.
-* Full support of Windows Azure service bus.
+$release_notes = '
+* Full support of Queue, Blob and Table services.
+* Full support of Service Bus.
+* Full support of Service Runtime.
* Support for storage services and affinity groups management operations.
';
+$default_pear_channel = 'pear.php.net';
+$dependencies = array(
+ array('required', 'HTTP_Request2', $default_pear_channel),
+ array('required', 'Mail_Mime', $default_pear_channel),
+ array('required', 'Mail_mimeDecode', $default_pear_channel),
+ array('optional', 'PEAR_PackageFileManager2', $default_pear_channel),
+);
$p = &PEAR_PackageFileManager2::importOptions(
dirname(__FILE__) . DIRECTORY_SEPARATOR . 'package.xml',
@@ -62,19 +77,18 @@
$p->addRelease();
$p->clearDeps();
$p->setChannel($channel);
-$p->setLicense('Apache 2.0', 'https://github.com/WindowsAzure/azure-sdk-for-php/blob/master/LICENSE.txt');
+$p->setLicense($license, $license_agreement);
$p->setReleaseVersion($release_version);
-$p->setAPIVersion('1.0.0');
+$p->setAPIVersion($api_version);
$p->setReleaseStability($release_state);
-$p->setAPIStability('stable');
-$p->setPhpDep('5.3.0');
+$p->setAPIStability($api_state);
+$p->setPhpDep($min_php_version);
// If this run twice the lead entry will be duplicated. Make sure that it just run once.
//$p->addMaintainer('lead', 'AzurePHPSDK', 'Azure PHP SDK', 'azurephpsdk@microsoft.com');
-$p->setPearinstallerDep('1.8.0');
-$p->addPackageDepWithChannel('required', 'HTTP_Request2', 'pear.php.net');
-$p->addPackageDepWithChannel('required', 'Mail_Mime', 'pear.php.net');
-$p->addPackageDepWithChannel('required', 'Mail_mimeDecode', 'pear.php.net');
-$p->addPackageDepWithChannel('optional', 'PEAR_PackageFileManager2', 'pear.php.net');
+$p->setPearinstallerDep($min_pear_version);
+foreach($dependencies as $dependency) {
+ $p->addPackageDepWithChannel($dependency[0], $dependency[1], $dependency[2]);
+}
// The replacement doesn't work check: https://github.com/WindowsAzure/azure-sdk-for-php/issues/413
$p->addReplacement('WindowsAzure/*.php', 'package-info', '@package_version@', 'version');
$p->generateContents();
View
@@ -1,33 +1,35 @@
<?xml version="1.0" encoding="UTF-8"?>
<package packagerversion="1.9.4" version="2.0" xmlns="http://pear.php.net/dtd/package-2.0" xmlns:tasks="http://pear.php.net/dtd/tasks-1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://pear.php.net/dtd/tasks-1.0 http://pear.php.net/dtd/tasks-1.0.xsd http://pear.php.net/dtd/package-2.0 http://pear.php.net/dtd/package-2.0.xsd">
<name>WindowsAzure</name>
- <channel>pear.windowsazure.com</channel>
+ <channel>pear.blob.core.windows.net</channel>
<summary>
-Summary for Windows Azure SDK for PHP
+Official PHP SDK for Microsoft Windows Azure.
</summary>
<description>
-Description for Windows Azure SDK for PHP
+The Windows Azure client libraries provide easy access to all Windows Azure REST services
+including Tables, Blobs, Queues, Service Bus, Service Management and Service Runtime.
</description>
<lead>
<name>Azure PHP SDK</name>
<user>AzurePHPSDK</user>
<email>azurephpsdk@microsoft.com</email>
<active>yes</active>
</lead>
- <date>2012-05-30</date>
- <time>23:04:06</time>
+ <date>2012-05-31</date>
+ <time>11:34:25</time>
<version>
- <release>1.0.0</release>
- <api>1.0.0</api>
+ <release>0.1.0</release>
+ <api>0.1.0</api>
</version>
<stability>
- <release>stable</release>
- <api>stable</api>
+ <release>beta</release>
+ <api>beta</api>
</stability>
- <license uri="https://github.com/WindowsAzure/azure-sdk-for-php/blob/master/LICENSE.txt">Apache 2.0</license>
+ <license uri="http://www.apache.org/licenses/LICENSE-2.0">Apache 2.0</license>
<notes>
-* Full support of Windows Azure sotrage services Queue, Blob and Table.
-* Full support of Windows Azure service bus.
+* Full support of Queue, Blob and Table services.
+* Full support of Service Bus.
+* Full support of Service Runtime.
* Support for storage services and affinity groups management operations.
</notes>
<contents>
@@ -275,18 +277,19 @@ Description for Windows Azure SDK for PHP
<changelog>
<release>
<version>
- <release>1.0.0</release>
- <api>1.0.0</api>
+ <release>0.1.0</release>
+ <api>0.1.0</api>
</version>
<stability>
- <release>stable</release>
- <api>stable</api>
+ <release>beta</release>
+ <api>beta</api>
</stability>
- <date>2012-05-30</date>
- <license uri="https://github.com/WindowsAzure/azure-sdk-for-php/blob/master/LICENSE.txt">Apache 2.0</license>
+ <date>2012-05-31</date>
+ <license uri="http://www.apache.org/licenses/LICENSE-2.0">Apache 2.0</license>
<notes>
-* Full support of Windows Azure sotrage services Queue, Blob and Table.
-* Full support of Windows Azure service bus.
+* Full support of Queue, Blob and Table services.
+* Full support of Service Bus.
+* Full support of Service Runtime.
* Support for storage services and affinity groups management operations.
</notes>
</release>

0 comments on commit 049e14d

Please sign in to comment.