Permalink
Browse files

Apply code review

  • Loading branch information...
1 parent 41f804c commit a8fea3572ac7908cf537b481a0ec9518f3029f07 Abdelrahman Elogeel committed Jun 26, 2012
Showing with 7 additions and 8 deletions.
  1. +3 −3 .gitignore
  2. +1 −1 build.xml
  3. +3 −4 {tools → build}/ChannelManager.php
View
@@ -4,9 +4,9 @@ build/coverage
build/logs
build/pdepend
build/phpdox
-tools/channel
+build/channel
+build/*.tgz
phpunit.xml
cache.properties
vendor
-nbproject
-tools/*.tgz
+nbproject
View
@@ -191,7 +191,7 @@
<target name="new-pear-release" description="Adds new release to PEAR channel">
<exec executable="php.exe">
- <arg path="${basedir}/tools/ChannelManager.php" />
+ <arg path="${basedir}/build/ChannelManager.php" />
<arg value="release" />
</exec>
</target>
@@ -302,10 +302,11 @@ private static function _uploadChannel()
*/
private static function _rscandir($dir, &$files) {
foreach(glob($dir . '/*') as $file) {
- if(is_dir($file))
+ if(is_dir($file)) {
self::_rscandir($file, $files);
- else
+ } else {
$files[] = $file;
+ }
}
}
@@ -450,8 +451,6 @@ private static function _promptMsg($msg, $isYesNoMsg = false)
}
}
-
-// Start the script
ChannelManager::main();
?>

0 comments on commit a8fea35

Please sign in to comment.