From ddddac30a9ea629dcf734ba5e8e7db0d092cdb26 Mon Sep 17 00:00:00 2001 From: Swathi Pillalamarri Date: Thu, 10 Feb 2022 13:19:04 -0800 Subject: [PATCH 1/2] fix mypy 0.931 errors --- sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py | 2 +- .../azure-servicebus/azure/servicebus/_servicebus_receiver.py | 3 ++- .../azure/servicebus/aio/_servicebus_receiver_async.py | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py b/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py index c33191b12eeb6..cb6b683a19f74 100644 --- a/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py +++ b/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py @@ -46,7 +46,7 @@ from azure.core.credentials import TokenCredential _LOGGER = logging.getLogger(__name__) -_Address = collections.namedtuple("Address", "hostname path") +_Address = collections.namedtuple("Address", "hostname path") # type: ignore def _parse_conn_str(conn_str, **kwargs): diff --git a/sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py b/sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py index 61df911354fb6..7d94131968e29 100644 --- a/sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py +++ b/sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py @@ -8,7 +8,7 @@ import uuid import datetime import warnings -from typing import Any, List, Optional, Dict, Iterator, Union, TYPE_CHECKING +from typing import Any, List, Optional, Dict, Iterator, Union, TYPE_CHECKING, cast import six @@ -692,6 +692,7 @@ def receive_deferred_messages( raise ValueError("The timeout must be greater than 0.") if isinstance(sequence_numbers, six.integer_types): sequence_numbers = [sequence_numbers] + sequence_numbers = cast(List[int], sequence_numbers) if len(sequence_numbers) == 0: return [] # no-op on empty list. self._open() diff --git a/sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_receiver_async.py b/sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_receiver_async.py index 6cd191b03855c..34d4758331aa5 100644 --- a/sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_receiver_async.py +++ b/sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_receiver_async.py @@ -8,7 +8,7 @@ import functools import logging import warnings -from typing import Any, List, Optional, AsyncIterator, Union, Callable, TYPE_CHECKING +from typing import Any, List, Optional, AsyncIterator, Union, Callable, TYPE_CHECKING, cast import six @@ -678,6 +678,7 @@ async def receive_deferred_messages( raise ValueError("The timeout must be greater than 0.") if isinstance(sequence_numbers, six.integer_types): sequence_numbers = [sequence_numbers] + sequence_numbers = cast(List[int], sequence_numbers) if len(sequence_numbers) == 0: return [] # no-op on empty list. await self._open() From 0d25875c39b36407b893b584e03786f6f1bff906 Mon Sep 17 00:00:00 2001 From: Swathi Pillalamarri Date: Tue, 15 Feb 2022 11:54:31 -0800 Subject: [PATCH 2/2] update tuple naming --- sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py b/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py index cb6b683a19f74..9249b9eea8ffd 100644 --- a/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py +++ b/sdk/eventhub/azure-eventhub/azure/eventhub/_client_base.py @@ -46,7 +46,7 @@ from azure.core.credentials import TokenCredential _LOGGER = logging.getLogger(__name__) -_Address = collections.namedtuple("Address", "hostname path") # type: ignore +_Address = collections.namedtuple("_Address", "hostname path") def _parse_conn_str(conn_str, **kwargs):