[evaluation] Fix xpia simulator logging warning #37351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
MilesHolland
approved these changes
Sep 12, 2024
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
nagkumar91
approved these changes
Sep 12, 2024
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* Remove Optional type annotation from get() methods * Remove duplicate overloads * Include xpia in handled_metrics for evaluation aggregation * Remove jailbreak_type param from logging attributes * Rename xpia_simulator.py to indirect_attack_simulator.py' * Remove old commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AdversarialSimulatoremits a logging warning when called. This is due to opencensus telemetry not allowing NoneType values to be set as logging attributes and_jailbreak_typecan be None. To fix this, this PR removes_jailbreak_typeas an attribute and instead uses the activity name to distinguish the simulators in logs.This PR also renames
xpia_simulator.pytoindirect_attack_simulator.pyto matchdirect_attack_simulator.py.If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines