Skip to content

Commit 18eadba

Browse files
committed
Resolve PR feedback
1 parent 31e82ff commit 18eadba

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sdk/core/azure_core/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
180180

181181
### Consuming service methods returning `Pager<T>`
182182

183-
If a service call returns multiple values in pages, it would return `Result<Pager<T>>` as a result. You can iterate all items from all pages.
183+
If a service call returns multiple values in pages, it should return `Result<Pager<T>>` as a result. You can iterate all items from all pages.
184184

185185
```rust no_run
186186
use azure_identity::DefaultAzureCredential;
@@ -248,7 +248,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
248248

249249
### Consuming service methods returning `Poller<T>`
250250

251-
If a service call may take a while to process, it would return `Result<Poller<T>>` as a result, representing a long-running operation (LRO).
251+
If a service call may take a while to process, it should return `Result<Poller<T>>` as a result, representing a long-running operation (LRO).
252252
The `Poller<T>` implements `futures::Stream` so you can asynchronously iterate over each status monitor update:
253253

254254
```rust no_run

sdk/core/azure_core/src/http/poller.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ use std::{
2323
/// Default retry time for long-running operations if no retry-after header is present
2424
///
2525
/// This value is the same as the default used in other Azure SDKs e.g.,
26-
/// <https://github.com/Azure/azure-sdk-for-python/blob/azure-mgmt-core_1.5.0/sdk/core/azure-mgmt-core/azure/mgmt/core/polling/arm_polling.py#L191>
26+
/// <https://github.com/Azure/azure-sdk-for-python/blob/azure-core_1.35.0/sdk/core/azure-core/azure/core/polling/base_polling.py#L586>
2727
const DEFAULT_RETRY_TIME: Duration = Duration::seconds(30);
2828
const MIN_RETRY_TIME: Duration = Duration::seconds(1);
2929

0 commit comments

Comments
 (0)