Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log unrecongnized resource quota parts instead of returning an error #1291

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

tcallan
Copy link
Contributor

@tcallan tcallan commented Jun 6, 2023

Fixes #1137

An alternate solution (or possible addition to this change) would be to capture the resource quota parts that were triggering the error. The parts in question are not useful to me and I'm not sure if they are generally useful so I didn't make that change.

@heaths
Copy link
Member

heaths commented Jun 6, 2023

@JeffreyRichter do you see any problem with this? Cosmos is sending back a header value we weren't expecting, and rather than err (not the caller's fault) we simply warn (part of the tracing)?

@JeffreyRichter
Copy link
Member

I'm missing the full context on this, but I think not erroring is correct. I also think that not warning may also be correct. What is the value of warning? Would you also warn if an undocumented response header came back from the service?

@tcallan
Copy link
Contributor Author

tcallan commented Jun 6, 2023

FWIW, the warning is there mostly out of excessive caution, just in case it happens to be useful to someone, because I'm relatively unfamiliar with this code. I have zero objections to removing it.

Edit: I went ahead and removed the warning.

@heaths
Copy link
Member

heaths commented Jun 6, 2023

BTW, we squash-merge so your fork's main will be different than the upstream main. I recommend always creating a topic branch in your fork and open a PR to merge that into main, such that your main is always in sync - if not behind, but fast-forwardable - with upstream main.

@heaths heaths merged commit 058fdcf into Azure:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_data_cosmos error: resource quota has an unrecognized part
3 participants