move to using tracing instead of log
#1579
Conversation
In order to move towards supporting OpenTelemetry, we need to move the underlying logging implementation to use `tracing`. This does _not_ start exposing spans or tracing state yet. ref: https://azure.github.io/azure-sdk/general_implementation.html
There was a problem hiding this comment.
I saw quite a few files where a use tracing::trace was added but no obvious indication of use. If a use log::trace were removed (and in some places it was), that makes sense; however, it's puzzling to see one without the other. Were log::trace instances left behind? I expanded a few files and didn't see any, but it was a small sample. I'd just ask that you double check if not sure. I suppose as long as the log crate was removed from all manifests it shouldn't be possible to use.
| @@ -17,7 +17,7 @@ async-trait = "0.1" | |||
| azure_core = { path = "../core", version = "0.19" } | |||
| time = "0.3.10" | |||
| futures = "0.3" | |||
| log = "0.4" | |||
| tracing = "0.1.40" | |||
There was a problem hiding this comment.
Not to block this PR, but wondering if we should switch to workspace-inherited dependencies to better manage these centrally like we do in Azure/azure-sdk-for-net and, I believe, some other languages that allow for it.
| @@ -1,5 +1,6 @@ | |||
| use super::AuthorizationToken; | |||
| use azure_core::{auth::Secret, base64}; | |||
| use tracing::trace; | |||
There was a problem hiding this comment.
Is this even used that you could just add a use and not remove one to, say, log::trace?
There was a problem hiding this comment.
I tagged you in a comment that shows the change that resulted this change.
| #[macro_use] | ||
| extern crate log; |
There was a problem hiding this comment.
@heaths, this is what required the inclusion of tracing::trace and the like in a handful of places.
Rather than import all of the macros from the tracing crate implicitly, this PR move to explicitly using the intended macros in the intended locations.
In order to move towards supporting OpenTelemetry for distributed tracing, we need to move the underlying logging implementation to use
tracing.This does not start exposing spans or tracing state yet.
ref: https://azure.github.io/azure-sdk/general_implementation.html