Use vcpkg steps from eng/common #3215
Merged
+1
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
RickWinter,
hallipr,
heaths and
weshaggard
as code owners
danieljurek
added
the
Central-EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates vcpkg setup steps by replacing repository-specific configuration with a shared template from eng/common. This change addresses recent vcpkg breaking changes and centralizes configuration management to simplify recovery from future breaking changes across multiple repositories.
Key Changes:
- Replaces inline PowerShell script for setting vcpkg environment variables with a shared template
- Removes conditional logic for setting up write-mode cache on internal builds
4 tasks
|
/azp run rust - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
approved these changes
Oct 16, 2025
|
@microsoft-github-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Azure/azure-sdk-tools#12291
vcpkg recently released a breaking change that caused errors in 4 different repos. Since vcpkg has spread to wider use, this PR uses a unified vcpkg specified in
eng/commonwhich will make it easier to recover from breaking changes to vcpkg in the future.