Skip to content

Option macro improvements #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 22, 2022
Merged

Option macro improvements #955

merged 5 commits into from
Jul 22, 2022

Conversation

@rylev
Copy link
Contributor

@rylev rylev commented Jul 22, 2022

Building off of #953:

  • Use /// annotation instead of #[doc]
  • Rename request_query_option to request_query to mirror request_header
  • Allow there to be no trailing commas in request_header
  • Share the internals of the macro so that they only need to be changed once
  • Do some small house keeping

@rylev rylev requested a review from bmc-msft July 22, 2022 08:33
@bmc-msft bmc-msft merged commit a5a9486 into Azure:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bmc-msft bmc-msft bmc-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rylev @bmc-msft