Run API stub generator using published package #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
reviewed
Apr 6, 2022
| @@ -17,29 +17,27 @@ public class PythonLanguageService : LanguageProcessor | |||
| { | |||
| public override string Name { get; } = "Python"; | |||
| public override string Extension { get; } = ".whl"; | |||
| public override string VersionString { get; } = "0.2.8"; | |||
| public override string VersionString { get; } = "0.2.11"; | |||
There was a problem hiding this comment.
What is this needed for (I can see I haven't updated it--oops)?
There was a problem hiding this comment.
we already published 0.2.10 to feed. I need latest changes in this PR to integrate published package to APIVIew to run stubgen as a module. So only option is to publish a new version and refer the same when generating/ checking if update is required.
There was a problem hiding this comment.
This property is still used to check if we need to auto update an existing review or not.
praveenkuttappan
added
the
Central-EngSys
tjprescott
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has changes to optimize virtual env creation step to use APP-DATA and symlinks and also run api stub gen using package module.