Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple endpoint from configs #341

Merged
merged 8 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@vicancy
Copy link
Contributor

commented Jan 15, 2019

  1. For Core One, support setting multiple endpoints from IConfiguration with key starts with
    Azure:SignalR:ConnectionString: or ConnectionStrings:Azure:SignalR:ConnectionString:
  2. For AspNet one, support setting multiple endpoints from config file, from ConnectionStrings section, and AppSettings section as fallback, with key starts with Azure:SignalR:ConnectionString:

vicancy added some commits Jan 15, 2019

vicancy added some commits Jan 16, 2019

for (int i = 0; i < count; i++)
{
var setting = ConfigurationManager.ConnectionStrings[i];
var se = GetEndpoint(setting.Name, () => setting.ConnectionString);

This comment has been minimized.

Copy link
@vwxyzh

vwxyzh Jan 17, 2019

Contributor

var (endpoint , isDefault) = ...

@vwxyzh

vwxyzh approved these changes Jan 17, 2019

@vicancy vicancy merged commit e6c3295 into Azure:dev Jan 17, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@vicancy vicancy deleted the vicancy:options branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.