Fix/enable body read retries and logging #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Same as already in Blob/File SDKs)
Without this, we can see very occasional chunks that are orders of magnitude slower than normal. That becomes a problem given our desire to process the files sequentially (for MD5 computation and, in some cases, disk performance). Root cause of the slowness is yet to be determined, but this workaround is effective for now.
rickle-msft
pushed a commit
to rickle-msft/azure-storage-azcopy
that referenced
this pull request
Feb 19, 2019
* Port forced retry and better logging to the azbfs retry reader (Same as already in Blob/File SDKs) * Enable logging of retries in response body downloads * Force body read retries when a downloaded chunk is abnormally slow Without this, we can see very occasional chunks that are more than an order of magnitude slower than normal. That becomes a problem given our desire to process the files sequentially (for MD5 computation and, in some cases, disk performance). Root cause of the slowness is yet to be determined, but this workaround is effective for now. * Update "dep" dependency of blob SDK to latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two related changes to the way we read response bodies in downloads: