Add public_access property to attr map #436
Conversation
| 'content-range': (None, 'content_range', _to_str), | ||
| 'x-ms-blob-sequence-number': (None, 'page_blob_sequence_number', _to_int), | ||
| 'x-ms-blob-committed-block-count': (None, 'append_blob_committed_block_count', _to_int), | ||
| 'x-ms-blob-public-access': (None, 'public_access', _to_str), |
There was a problem hiding this comment.
Hi, are you making this change because you wanted the public access info when calling get_container_properties?
Btw there's a separate API specifically for getting this property. And the deserialization was done here.
There was a problem hiding this comment.
Yes, it doesn't make sense for the container property model to have "public_access" but not be able to deserialize it from the response.
https://github.com/Azure/azure-storage-python/blob/master/azure-storage-blob/azure/storage/blob/models.py#L48
This results in the property always having the value None
There was a problem hiding this comment.
@williexu That's a good point. Could you please add a test+recording for this change? Thanks!
azure-storage-common/setup.py
Outdated
| setup( | ||
| name='azure-storage-common', | ||
| version='1.1.0', | ||
| version='1.1.1', |
There was a problem hiding this comment.
Please do not increment version numbers in PRs.
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
- Coverage 86.06% 86.04% -0.03%
==========================================
Files 56 56
Lines 4429 4429
Branches 481 481
==========================================
- Hits 3812 3811 -1
Misses 465 465
- Partials 152 153 +1
Continue to review full report at Codecov.
|
|
@zezha-msft added testing, let me know if there are any other issues with this |
|
@williexu looking good! Do you mind creating the PR against Dev instead of master? |
|
Done, :) |
|
@williexu Thanks! |
3 participants
-The
public_accessproperty of a ContainerProperties is not being deserialized fromx=ms-blob-public-accessin the response-added property to map and bumped patch version