Skip to content

Conversation

@rongduan-zhu
Copy link
Contributor

Empty query strings are included in the path but they are not signed. This change will make sure that all the query params that's not None are signed.

@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #452 into dev will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #452      +/-   ##
==========================================
- Coverage   85.85%   85.83%   -0.03%     
==========================================
  Files          56       56              
  Lines        4447     4447              
  Branches      485      485              
==========================================
- Hits         3818     3817       -1     
  Misses        475      475              
- Partials      154      155       +1
Impacted Files Coverage Δ
azure-storage-common/azure/storage/common/_auth.py 84.37% <100%> (ø) ⬆️
...torage-blob/azure/storage/blob/_upload_chunking.py 71.42% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0ff4a...ef877ea. Read the comment docs.

@rongduan-zhu
Copy link
Contributor Author

@zezha-msft please let me know if you like this fix or prefer to just update the docs to tell people that they should not pass in an empty string for the prefix. I personally prefer this fix as this is actively stopping users from stuffing up.

@zezha-msft zezha-msft changed the base branch from master to dev May 1, 2018 19:15
@zezha-msft
Copy link
Contributor

Hi @rongduan-zhu, thanks for the PR!

Could you please rebase the branch on top of dev?

lmazuel and others added 2 commits May 1, 2018 14:08
Empty query strings are included in the path but they are not signed. This change will make sure that all the query params that's not `None` are signed.
@zezha-msft zezha-msft merged commit e79e6d9 into Azure:dev May 1, 2018
@rongduan-zhu rongduan-zhu deleted the patch-1 branch May 1, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants